-
Notifications
You must be signed in to change notification settings - Fork 305
ci: run Claude Opus 5.5 with a supported CLI #3432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+63
−12
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The new Install Claude Code step has no continue-on-error, so an npm hiccup or a CLI version mismatch now hard-fails the job even though the Claude action step right after it still has continue-on-error: true. In run-sweep.yml this is inside the 'setup' job (run-sweep.yml:269-276); every eval job is gated on needs.setup.result == 'success' (run-sweep.yml:860), so a flaky install now skips the whole sweep instead of degrading to the '["patchwork"]' fallback at run-sweep.yml:329. Same gap in klaud-plan.yml:69-76 (continue-on-error at klaud-plan.yml:80) and klaud-candidate.yml:65-71 (continue-on-error at klaud-candidate.yml:74). Fix: add continue-on-error: true to each new Install step so it fails no harder than the step it precedes. [also at: .github/workflows/klaud-plan.yml:75 - Maintainers now get a hard job failure (and skipped downstream steps) from a transient npm/CLI issue, where the base only failed the Claude call itself.]
Why this was flagged
Trigger: an npm registry blip or claude-code version drift makes the
test "$("$claude_cli" --version)" = "2.1.282 (Claude Code)"assertion fail in the 'Install Claude Code 2.1.282' step (run-sweep.yml:269-276, klaud-plan.yml:69-76, klaud-candidate.yml:65-71). That step lacks continue-on-error, so GitHub Actions marks the whole job failed regardless of later steps' continue-on-error. In run-sweep.yml this step lives in 'setup'; 'Classify priority criteria' (run-sweep.yml:277-282) has continue-on-error: true and 'Normalize priority classification' (run-sweep.yml:319-331) already falls back to '["patchwork"]', proving the workflow was built to tolerate Claude-call failures. But the Install step now fails 'setup' outright, so every downstream eval job gated on needs.setup.result == 'success' (run-sweep.yml:860) is skipped. Before this diff there was no Install step, so only the continue-on-error-protected action could fail, and 'setup'…Verification: normal (conflicts with stated purpose, partially): merging introduces a new hard-fail point that the base branch does not have, in code whose whole design is best-effort/non-blocking. Facts, run-sweep.yml: - The new step (269-276)
Install Claude Code 2.1.282has nocontinue-on-error; line 275test "$("$claude_cli" --version)" = "2.1.282 (Claude Code)"(and thenpm installat 273)…