Skip to content

[Klaud Cold] Update qwen3.5-fp4-mi355x-sglang-agentic-mtp to v0.5.20-rocm720-mi35x-20260924 and port #3364 TP2 conc / hicache-size tuning - #3455

Open
functionstackx wants to merge 3 commits into
mainfrom
klaud/qwen3.5-fp4-mi355x-sglang-agentic-mtp-v0.5.20-20260924
Open

functionstackx wants to merge 3 commits into
mainfrom
klaud/qwen3.5-fp4-mi355x-sglang-agentic-mtp-v0.5.20-20260924

Conversation

@functionstackx

@functionstackx functionstackx commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Update the SGLang ROCm image from v0.5.19-rocm720-mi35x-20260915 to v0.5.20-rocm720-mi35x-20260924 (latest nightly) for the Qwen3.5 FP4 MI355X AgentX recipe, and port the concurrency / HiCache tuning from #3364 onto the srt-slurm recipe that #3428 switched this config to. The same image passed the Qwen3.5 FP8/FP4 MI355X 8k1k sweeps (#3423, #3439).

Recipes touched: qwen3.5-fp4-mi355x-sglang-agentic-mtp

Changes:

  • configs/amd-master.yaml: image bump; TP2 GPU-resident conc-list [1, 4, 8, 12, 16, 20] → [1, 4, 8, 12], TP2 HiCache conc-list [20, …, 40] → [16, 20, 24, 28, 32, 36, 40]. TP4 stays [1, 4, 8, 12, 16].
  • srt-slurm-recipes/qwen3.5/sglang/mi355x-fp4-mtp/agentic.yaml: container bump; every HiCache variant pins hicache-size: 253 (overrides hicache-ratio); drops the now-unused tp2_c16 / tp2_c20 GPU-resident variants and adds tp2_c16_hicache. Verified locally with infx.srt_slurm.single_node.select_recipe that all 16 matrix points resolve to exactly one variant.
  • perf-changelog.yaml: new entry.

Supersedes #3364, which made the same changes against the retired benchmarks/single_node/agentic/qwen3.5_fp4_mi355x_sglang_mtp.sh bash script.

Test plan

  • full-sweep-enabled sweep passes.

🤖 Generated with Claude Code

@functionstackx
functionstackx requested a review from a team September 26, 2026 05:24
… image to v0.5.20-rocm720-mi35x-20260924

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps only run on labeled PRs. Add full-sweep-fail-fast (strongly recommended); use full-sweep-enabled only when matrix jobs should continue after a failure.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**扫描仅在带有标签的 PR 上运行。强烈建议添加 full-sweep-fail-fast;仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

functionstackx and others added 2 commits September 26, 2026 01:27
TP2 GPU-resident KV now covers [1, 4, 8, 12] and TP2 HiCache
[16, 20, 24, 28, 32, 36, 40]; every HiCache variant pins
hicache-size 253. Drops the now-unused tp2_c16/tp2_c20 resident
variants and adds tp2_c16_hicache so each matrix point resolves to
exactly one recipe variant.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…55x-sglang-agentic-mtp-v0.5.20-20260924

# Conflicts:
#	perf-changelog.yaml
@functionstackx functionstackx changed the title [Klaud Cold] Update qwen3.5-fp4-mi355x-sglang-agentic-mtp SGLang ROCm image to v0.5.20-rocm720-mi35x-20260924 [Klaud Cold] Update qwen3.5-fp4-mi355x-sglang-agentic-mtp to v0.5.20-rocm720-mi35x-20260924 and port #3364 TP2 conc / hicache-size tuning Sep 26, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Comment thread perf-changelog.yaml Outdated
- "This image bump does not change the DSpark draft model data type. Only the image: line changes and kimik3_fp4_mi355x_mtp.sh is unchanged; the draft loads unmodified from the published Inferact/Kimi-K3-DSpark checkpoint via --speculative-config (model=Inferact/Kimi-K3-DSpark, method=dspark). The only dtype in that speculative-config is kv_cache_dtype=fp8, which sets the draft KV-cache storage precision, not the draft weights. No flag overrides or re-quantizes the draft-model weights, so the draft dtype is preserved from its checkpoint across this re-sweep."
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/3419
- "Update SGLang ROCm image from v0.5.19-rocm720-mi35x-20260915 to v0.5.20-rocm720-mi35x-20260924 (latest nightly)"
pr-link: PRLINK_PLACEHOLDER

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 (optional) perf-changelog.yaml's new entry has pr-link: PRLINK_PLACEHOLDER instead of a real PR URL, violating the requirement that every changelog entry carry a real pr-link. Since the file is append-only and byte-sensitive, merging this leaves a permanent placeholder in history that never gets corrected retroactively. Fix: replace PRLINK_PLACEHOLDER with the actual PR URL before merge (compare other entries, e.g. the prior entry's pr-link: #3334, for the expected format).

Why this was flagged

perf-changelog.yaml:8958 sets pr-link: PRLINK_PLACEHOLDER for the new qwen3.5-fp4-mi355x-sglang-agentic-mtp entry. The file is documented as append-only, so once merged this placeholder cannot be fixed by editing the entry later without violating that invariant. Anyone auditing the changelog for this image bump (e.g. to find the PR that introduced v0.5.20-rocm720-mi35x-20260924) gets a dead literal string instead of a link. Base branch entries all carry real GitHub PR URLs (e.g. pull/3334 just above), so this is a regression in changelog completeness introduced by this diff.

Verification: nit. The candidate is factually present. perf-changelog.yaml:8958 (the new qwen3.5-fp4-mi355x-sglang-agentic-mtp entry appended at the tail) sets pr-link: PRLINK_PLACEHOLDER, a literal placeholder rather than a real URL. Every other entry carries a real GitHub PR URL, e.g. the immediately preceding entry at line 8952 pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/3334, and…

@github-actions

Copy link
Copy Markdown
Contributor

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant