Skip to content

[Klaud Cold] Delete 53 unused legacy single-node AgentX scripts from benchmarks/single_node/agentic #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
functionstackx merged 1 commit into from
Sep 26, 2026
Merged

[Klaud Cold] Delete 53 unused legacy single-node AgentX scripts from benchmarks/single_node/agentic #3460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions benchmarks/single_node/agentic/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Agentic single-node benchmarks

> **Legacy.** Single-node AgentX configs now run as declarative srt-slurm
> recipes (`benchmarks/single_node/srt-slurm-recipes/<model>/<engine>/<sku>/agentic.yaml`,
> see #3428). The only bash scripts left here are the ones a master config still
> reaches through a search-space entry without an `srt-recipe:`; delete each one

@claude claude Bot Sep 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 nit (optional): the new README note says the kept files are install_h1{0,2}0_block32_configs.py, but that brace expansion actually yields install_h100_block32_configs.py and install_h120_block32_configs.py, not the real install_h200_block32_configs.py. Fix: write install_h{100,200}_block32_configs.py (or spell both names out) so it correctly refers to the two files that actually exist.

Why this was flagged

The README text at benchmarks/single_node/agentic/README.md:6 uses shell brace-expansion notation install_h1{0,2}0_block32_configs.py, which expands to install_h100_block32_configs.py and install_h120_block32_configs.py. The actual second file is install_h200_block32_configs.py, which the pattern never names. A reader following this doc pointer to find the H200 install script will not find one matching the literal notation and may miss it, unlike a correct brace pattern such as install_h{100,200}_block32_configs.py.

Verification: nit: README.md:7 writes install_h1{0,2}0_block32_configs.py. Under shell brace-expansion the {0,2} sits between install_h1 and 0, so it yields install_h100_block32_configs.py and install_h120_block32_configs.py. The real files (confirmed via ls) are install_h100_block32_configs.py and install_h200_block32_configs.py; install_h120... does not exist and the H200 name is never…

> when its config is ported. `install_h1{0,2}0_block32_configs.py` and
> `kernel_configs/` also serve the multi-node DeepSeek-V4.1-Flash H100/H200 recipes.

**MVP / experimental.** Nothing in this directory is an official InferenceX
benchmark. Results are not published on https://inferencex.com and are not
intended to be cited.

@claude claude Bot Sep 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 (optional) This commit deletes 52 retired agentic scripts and check_dsv4_dspark_checkpoint.py outright instead of moving them to a sibling deprecated/ directory, breaking AGENTS.md's archival convention that the repo already follows elsewhere. AGENTS.md:60 says retired benchmark scripts move into a sibling deprecated/ directory, not get deleted, once no active config uses them; benchmarks/multi_node/deprecated/ and benchmarks/single_node/fixed_seq_len/deprecated/ hold 129+ files under this same rule. Fix: create benchmarks/single_node/agentic/deprecated/ and git-mv the 52 scripts plus check_dsv4_dspark_checkpoint.py there instead of removing them, matching the established pattern and preserving launch-flag/perf history for future reference.

Why this was flagged

AGENTS.md:60 requires retired scripts to move into a sibling deprecated/ directory once no active config uses them, not be deleted; the repo already applies this at benchmarks/multi_node/deprecated/ and benchmarks/single_node/fixed_seq_len/deprecated/. This commit instead git-rm's all 52 scripts and check_dsv4_dspark_checkpoint.py under benchmarks/single_node/agentic/ with no deprecated/ subdirectory created, unlike every other retirement in this repo. A maintainer who later needs the historical launch flags, kernel tuning, or perf context for these configs — preserved for every other retired script in the repo — cannot recover it, only via old git history rather than the browsable deprecated/ location the convention establishes.

Verification: nit. Factual claim holds: AGENTS.md:60 states "Follow the existing benchmark-script archival convention, moving retired scripts into the sibling deprecated/ directory only when no active config still uses them." The sibling deprecated/ directories cited exist and are in active use (benchmarks/multi_node/deprecated/ e.g. dsv4_fp4_gb200_llmd-vllm-disagg.sh;… | nit. Real deviation from a…

Expand Down
119 changes: 0 additions & 119 deletions benchmarks/single_node/agentic/check_dsv4_dspark_checkpoint.py
View file
Open in desktop

This file was deleted.

165 changes: 0 additions & 165 deletions benchmarks/single_node/agentic/dsv41flash_fp4_b200_sglang_mtp.sh
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion benchmarks/single_node/agentic/dsv41flash_fp4_b200_vllm_mtp.sh
View file
Open in desktop

This file was deleted.

Loading
Loading