[Klaud Cold] Delete benchmarks/multi_node/deprecated - #3467
Conversation
Nothing resolves or sources these 12 retired multi-node scripts. Drop the configuration-procedures link to the llmd-vllm wrapper (it pointed at a path that no longer existed) and reword the ATOM agentic comment that named its retired SGLang sibling. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Thanks for the contribution!
中文感谢你的贡献!
|
There was a problem hiding this comment.
Looks good, straightforward deletion of deprecated benchmark scripts. Reviewed the file deletions (12 retired multi-node scripts, no other content changes), confirmed via search that no remaining references to multi_node/deprecated exist in the repo, verified the two doc link fixes and the one comment tweak match the stated intent, and checked that the deleted script filenames only appear elsewhere in a historical perf-changelog.yaml log entry (not an active reference).
Extended reasoning...
Change is a pure deletion of 12 unused deprecated benchmark shell scripts plus two documentation link fixes and one comment update in a sibling script; no code logic, auth, or security-sensitive paths are touched. Confirmed via repo-wide search that no remaining code references the deleted paths, matching the PR description's safety claim. No CODEOWNERS concerns apparent and the diff is small and mechanical, so a human need not review this.
Summary
Delete
benchmarks/multi_node/deprecated/(12 retired multi-node scripts: DSv4 GB200 llm-d / MI355X ATOM+SGLang disagg, GLM-5 MI355X SGLang, gpt-oss GB200 Dynamo-TRT, Kimi-K2.5 MI355X ATOM+vLLM, MiniMax-M2.5/M3 MI355X ATOM+vLLM disagg). Continues the cleanup from #3460/#3461/#3463/#3464: retired assets are deleted, with git history as the record.Why this is safe
infx/,utils/or recipe referencesmulti_node/deprecated, and no active master config resolves any of these filenames (multi-node launchers look inbenchmarks/multi_node/, notdeprecated/).docs/configuration-procedures(_zh).md"Sources" line linked anllmd-vllmbenchmark wrapper atbenchmarks/multi_node/dsv4_fp4_gb200_llmd-vllm-disagg.sh, a path that already did not exist (the script lived only indeprecated/); the link is dropped.benchmarks/multi_node/agentic/dsv4_fp4_mi355x_atom-disagg.shheader comment now calls its SGLang sibling "former" (comment only).Test plan
git grepfinds no reference tomulti_node/deprecated;bash -non the edited agentic script.perf-changelog.yamlchange, so no sweep is triggered.🤖 Generated with Claude Code