Skip to content

Add support for a tag suffix in values#234

Closed
4ch3los wants to merge 1 commit into
Sentinel-One:masterfrom
4ch3los:feat/tag-suffix
Closed

Add support for a tag suffix in values#234
4ch3los wants to merge 1 commit into
Sentinel-One:masterfrom
4ch3los:feat/tag-suffix

Conversation

@4ch3los

@4ch3los 4ch3los commented Jun 10, 2025

Copy link
Copy Markdown

TLDR: This pr adds a additional values field, to provide a suffix for the tag, like -ga, -ea, ... This helps when replicating the images from the s1 registry.

When directly replicating the images from containers.sentinelone.net, images get suffixed with their release state (ga/ea). This resulst in the need to adjust the tag values for each upgrade. With this pr you can just provide -ga/-ea as suffix for you tag and simply update the helm chart,

… when replicating the s1 registry

Signed-off-by: Kai Fink <kai.fink@yahoo.de>
@oded-s1

oded-s1 commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator

Can we use the current tag param?

@4ch3los

4ch3los commented Jun 11, 2025

Copy link
Copy Markdown
Author

Can we use the current tag param?

Yes could definetly use the current tag param, but the downside is, that you always need to maintain your s1 version in two different locations(helm chart version + helm values).
With the option of a suffix, chart version and image version are in sync again. And you just need to update the chart when upgrading s1

@oded-s1

oded-s1 commented Nov 30, 2025

Copy link
Copy Markdown
Collaborator

@4ch3los Thanks for your PR.
Can you provide more information on why not using the tag param?

@4ch3los

4ch3los commented Jun 17, 2026

Copy link
Copy Markdown
Author

No longer needed, as values now contain the -ea or -ga by default, fine for me

@4ch3los 4ch3los closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants