Skip to content

Pr/tara/hr domain#46

Merged
tara-servicenow merged 88 commits intomainfrom
pr/tara/hr_domain
Apr 26, 2026
Merged

Pr/tara/hr domain#46
tara-servicenow merged 88 commits intomainfrom
pr/tara/hr_domain

Conversation

@tara-servicenow
Copy link
Copy Markdown
Collaborator

No description provided.

@tara-servicenow tara-servicenow marked this pull request as draft April 7, 2026 03:04
tara-servicenow and others added 26 commits April 7, 2026 03:06
- check_swap_eligibility: add runtime past-date check against _current_date
  (rejects shifts in the past instead of relying on pre-computed swap_locked)
- submit_payroll_correction: read pay_period_end_date from shift record instead
  of requiring it as a user-provided parameter; reject if pay period has closed
- Remove pay_period_end_date from SubmitPayrollCorrectionParams
- Update agent YAML: tool descriptions, remove pay_period_end_date param,
  update payroll policy to reflect automatic pay period validation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lso update tool to reject check in before leave end and update policy
…tension can be requested, and change DEA to pending object
@tara-servicenow tara-servicenow marked this pull request as ready for review April 26, 2026 21:47
Comment thread scripts/run_text_only.py
@@ -493,7 +493,7 @@ async def run_record(

audit_log = AuditLog()
agent_llm_client = LiteLLMClient(model=llm_model)
user_sim_llm_client = LiteLLMClient(model="gpt-5.2")
user_sim_llm_client = LiteLLMClient(model="gpt-5.1")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this committed on purpose?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. we use gpt-5.1 as the user in voice mode, not sure why it was 5.2 here before.

Comment thread configs/agents/medical_hr_agent.yaml Outdated
Comment on lines +493 to +494
enum: ["license_extension_submitted", "malpractice_updated", "privilege_reactivation"]
description: "The type of action being reported: license_extension_submitted, malpractice_updated, or privilege_reactivation"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detail - but I see a few description that repeats the enum - we could simplify

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed!

Copy link
Copy Markdown
Collaborator

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♀️ Colossal work - amazing Tara!!

I wonder if we should squash commits first so it doesn't make our git history on main "dirty," given there are a lot of intermediate commits?

@tara-servicenow tara-servicenow added this pull request to the merge queue Apr 26, 2026
Merged via the queue into main with commit 9e56c8b Apr 26, 2026
1 check passed
@tara-servicenow tara-servicenow deleted the pr/tara/hr_domain branch April 26, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants