Upgrade test application to Sylius 1.14 - #86
Merged
Conversation
Follows the Setono plugin skeleton 1.14.x branch: - setono/sylius-plugin-pack ~1.14.1 (Sylius 1.14, PHPStan, Rector 2, Infection 0.29) - Symfony constraints narrowed to ^6.4 (the only line Sylius 1.14 supports) - psalm.xml replaced by phpstan.neon (level max) with kernel/object manager loaders - src/ made PHPStan-clean without a baseline: generic EventSubscriber<TEvent> with an explicit track(object $event), generics on Sylius repositories and factories, typed fixture options, corrected @var hints - phpunit.xml.dist: remove stale AppKernel reference, add coverage config Claude-Session: https://claude.ai/code/session_013jh2QjzkxAJABPDYB1UiPS
- bundles.php in skeleton 1.14 order (state machine abstraction, calendar, SyliusTestPlugin, test_cached env), keeping the Setono bundles - Frontend built with @sylius-ui/frontend and Node 20 (.nvmrc); entries point at the vendored Sylius bundles, dead assets/ removed - Disable Sylius telemetry in the test application Claude-Session: https://claude.ai/code/session_013jh2QjzkxAJABPDYB1UiPS
PHP 8.1-8.3, Symfony ~6.4.0 only, actions/checkout@v5, Rector enforced, static analysis via composer analyse (PHPStan). Claude-Session: https://claude.ai/code/session_013jh2QjzkxAJABPDYB1UiPS
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
…eck installable - track() keeps its parameterless signature; the originating event is read from the first dispatcher argument and typed as TEvent, so Roave no longer reports an increased number of required arguments - The BC check job now disables Composer's security-advisory blocking globally: Roave installs the baseline's dependencies, and Sylius 1.x pins api-platform/core ^2.7 which has known advisories the base branch cannot opt out of itself Claude-Session: https://claude.ai/code/session_013jh2QjzkxAJABPDYB1UiPS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the test application from Sylius 1.12 to Sylius 1.14, using Setono/SyliusPluginSkeleton
1.14.xas the guide.Changes
Dependencies / tooling
setono/sylius-plugin-pack ~1.14.1→ Sylius 1.14.19, Symfony 6.4, API Platform 2.7; all Symfony constraints narrowed to^6.4(Sylius 1.14 supports^5.4.21 || ^6.4only)phpstan.neon+tests/PHPStanloaders, as in the skeleton).src/passes without a baseline; the only config additions areallowNullablePropertyForRequiredFieldand a commented ignore for interface-mapped Doctrine associations (Syliusresolve_target_entities).phpunit.xml.dist: staleAppKernel.phpreference removed, coverage config added.src/(type-level only, plus one Rector??=)EventSubscriberis generic over the originating event (@template TEvent),callback()returnscallable(TEvent): ?Event, andtrack()now takes the event explicitly (track(object $event)) instead offunc_get_args().@varhints.tests/Applicationbundles.phpin skeleton 1.14 order (SyliusStateMachineAbstractionBundle,SyliusTestPlugin,test_cached), keeping the Setono bundlespackage.json→@sylius-ui/frontend ^1.0.3, skeletonwebpack.config.js,.nvmrc(Node 20), deadassets/removedSYLIUS_TELEMETRY_ENABLED=0CI: PHP 8.1–8.3, Symfony
~6.4.0only,checkout@v5, Rector enforced,composer analyse.Verified locally (PHP 8.3)
composer update,composer normalize/validate --strictlint:container(dev + test),lint:yaml,lint:twigdoctrine:schema:create+schema:validate,sylius:fixtures:load(incl. the plugin's pixels)yarn install && yarn buildon Node 20dev.logshowsViewProductSubscriber::track→ConversionsApiEventRaised→ bundle subscribers with no errorsNotes
composer auditflags 4 advisories onapi-platform/core2.7 — unfixable while on Sylius 1.x (henceaudit.block-insecure: false, same as the skeleton).https://claude.ai/code/session_013jh2QjzkxAJABPDYB1UiPS