Skip to content

Add translations for 14 more locales - #58

Merged
loevgaard merged 1 commit into
3.xfrom
translations
Aug 31, 2026
Merged

Add translations for 14 more locales#58
loevgaard merged 1 commit into
3.xfrom
translations

Conversation

@loevgaard

@loevgaard loevgaard commented Aug 31, 2026

Copy link
Copy Markdown
Member

Adds complete messages and validators catalogues (all 24 UI keys and 5 validator messages) for:

  • Nordic: Swedish (sv), Norwegian (no), Finnish (fi) — Danish (da) already existed
  • Large EU: German (de), French (fr), Spanish (es), Italian (it), Dutch (nl), Polish (pl)
  • Other common Sylius locales: Portuguese (pt), Czech (cs), Hungarian (hu), Romanian (ro), Ukrainian (uk)

Notes:

  • Norwegian uses the no code, matching Sylius's own catalogues (messages.no.yml). Symfony's locale fallback goes nb_NOnb → default, so a shop configured with nb_NO will only pick this up if the app's fallback locales are set accordingly — same situation as Sylius core.
  • Portuguese follows European Portuguese ("Encomenda", "Gerir"); a pt_BR variant can be added on top if needed.
  • "Partner Ads" is kept as a brand name everywhere.

Verified: lint:yaml passes, every locale has exactly the English key set (scripted comparison), and the Symfony translator resolves all catalogues at runtime in the test app, including {{ compared_value }} substitution.

Swedish, Norwegian, Finnish, German, French, Spanish, Italian, Dutch,
Polish, Portuguese, Czech, Hungarian, Romanian, and Ukrainian, for both
the messages and validators domains. Norwegian uses the "no" code like
Sylius itself does.

Claude-Session: https://claude.ai/code/session_01Mt12J8vdGwwWg4V23uoEf9
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.79%. Comparing base (ed2e023) to head (dd44c9d).

Additional details and impacted files
@@            Coverage Diff            @@
##                3.x      #58   +/-   ##
=========================================
  Coverage     84.79%   84.79%           
  Complexity      104      104           
=========================================
  Files            21       21           
  Lines           546      546           
=========================================
  Hits            463      463           
  Misses           83       83           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loevgaard
loevgaard merged commit defc7a0 into 3.x Aug 31, 2026
94 checks passed
@loevgaard
loevgaard deleted the translations branch August 31, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant