Add translations for 14 more locales - #58
Merged
Merged
Conversation
Swedish, Norwegian, Finnish, German, French, Spanish, Italian, Dutch, Polish, Portuguese, Czech, Hungarian, Romanian, and Ukrainian, for both the messages and validators domains. Norwegian uses the "no" code like Sylius itself does. Claude-Session: https://claude.ai/code/session_01Mt12J8vdGwwWg4V23uoEf9
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.x #58 +/- ##
=========================================
Coverage 84.79% 84.79%
Complexity 104 104
=========================================
Files 21 21
Lines 546 546
=========================================
Hits 463 463
Misses 83 83 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds complete
messagesandvalidatorscatalogues (all 24 UI keys and 5 validator messages) for:sv), Norwegian (no), Finnish (fi) — Danish (da) already existedde), French (fr), Spanish (es), Italian (it), Dutch (nl), Polish (pl)pt), Czech (cs), Hungarian (hu), Romanian (ro), Ukrainian (uk)Notes:
nocode, matching Sylius's own catalogues (messages.no.yml). Symfony's locale fallback goesnb_NO→nb→ default, so a shop configured withnb_NOwill only pick this up if the app's fallback locales are set accordingly — same situation as Sylius core.pt_BRvariant can be added on top if needed.Verified:
lint:yamlpasses, every locale has exactly the English key set (scripted comparison), and the Symfony translator resolves all catalogues at runtime in the test app, including{{ compared_value }}substitution.