Allow facebook/php-business-sdk ^26.0 (Graph API v26.0) - #12
Merged
Conversation
Widen the constraint to "^25.0 || ^26.0" so consumers can pick up Graph API v26.0. The package is only used for ApiConfig::APIVersion, Normalizer::normalize and Util::hash, all of which are unchanged in 26.x. ClientTest::it_sends_event asserted a hardcoded v25.0 endpoint; it now derives the version from ApiConfig::APIVersion so it passes with either major. Closes #10
loevgaard
force-pushed
the
widen-facebook-sdk
branch
from
August 31, 2026 12:32
7f289c3 to
aba906f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10.
composer.json:facebook/php-business-sdkwidened from^25.0to^25.0 || ^26.0, so consumers can move to Graph API v26.0 (26.0.1 requires PHP >= 8.0,guzzlehttp/guzzle ^6.5 || ^7.0,facebook/capi-param-builder-php ^1.3.1).src/changes: the package is only used forApiConfig::APIVersion,Normalizer::normalizeandUtil::hash, all present and unchanged in 26.x — the existing tests that pin the hashed/normalized payloads pass unchanged against 26.0.1.ClientTest::it_sends_eventasserted a hardcodedv25.0endpoint, which would fail onhighest; it now derives the version fromApiConfig::APIVersion(same approach as the new tests in Improve test coverage to 100% and raise Infection thresholds #11).Test plan
composer update facebook/php-business-sdk --with-all-dependencies→ 26.0.1;ApiConfig::APIVersion=26.0vendor/bin/phpunit,vendor/bin/phpstan analyse,vendor/bin/ecs check,vendor/bin/composer-dependency-analyser,composer normalize --dry-run— all green on 26.0.1vendor/bin/phpuniton PHP 8.1 against 26.0.1lowestmatrixLiveClientTestagainst 26.x — run 2026-08-31 after merge (SDK 26.0.1, PHP 8.4): Meta returned 200 for theViewContenttest event.The aside in #10 (dropping the dependency in favour of an explicit API-version constant) is intentionally left for a separate discussion.