Reset the cached VAT context between requests - #7
Open
loevgaard wants to merge 1 commit into
Open
Conversation
CachedVatContext memoized the first answer for the lifetime of the service. Under PHP-FPM that is effectively per request, but worker based runtimes, i.e. FrankenPHP, RoadRunner and Swoole, keep services alive across requests, so the first visitor's VAT choice was served to every subsequent visitor and the toggle appeared to do nothing. Implement ResetInterface and tag the service with kernel.reset so the cache is cleared when the kernel is reset between requests. Claude-Session: https://claude.ai/code/session_01P9NzuVPQGvaVR97HZFq98a
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CachedVatContextmemoizes the first answer for the lifetime of the service and never clears it.Under PHP-FPM that is effectively "per request", so nobody notices. Under a worker based runtime — FrankenPHP, RoadRunner, Swoole — the container is kept alive across requests, so the first visitor's VAT choice sticks to the worker and is served to every subsequent visitor. From the shopper's side the toggle button simply stops working.
This makes the context implement
Symfony\Contracts\Service\ResetInterfaceand tags the service withkernel.reset, so Symfony clears the memoized value when it resets the kernel between requests.symfony/service-contractsis added torequiresince the interface is now used insrc/. It was already installed transitively viasymfony/dependency-injection.Addresses the second bug in #5.
https://claude.ai/code/session_01P9NzuVPQGvaVR97HZFq98a