Skip to content

Implement NotFoundError #18

Closed
Closed

Description

@codebestia

Description

Raised on HTTP 404 responses. Should include the resource type and ID that was not found, so the developer can distinguish a missing payment from a missing invoice without parsing the message string.

Proposed Steps

  • Define NotFoundError(ShadeError) in errors.py.
  • Add resource_type: Optional[str] and resource_id: Optional[str] attributes.
  • Populate from the 404 response body.

Acceptance Criteria

  • A 404 response raises NotFoundError.
  • error.resource_type and error.resource_id reflect the queried resource.
  • Subclasses ShadeError.

Activity

  1. Enemuo-debug commented on Jun 20, 2026

    @Enemuo-debug

    Can I please be opportuned to work on this??

  2. xJeffx23 commented on Jun 20, 2026

    @xJeffx23
    Contributor

    Hello!

    My name is Jefferson, and I have been contributing to open-source projects for over a year. I have participated in multiple hackathons and have experience working with SDKs, API integrations, and developer-focused tooling.

    I would like to work on this issue because structured error handling significantly improves the developer experience. Providing resource-specific information through a dedicated NotFoundError would make debugging easier and eliminate the need to parse error message strings to determine which resource was missing.

    My plan would be to introduce a NotFoundError class inheriting from ShadeError, populate the resource_type and resource_id fields from the API response payload, update the 404 handling logic accordingly, and add tests to verify the correct exception type and metadata are exposed to SDK consumers.

    I would greatly appreciate the opportunity to contribute to the project. Thank you for your time and consideration!

  3. grantfox-oss commented on Jun 23, 2026

    @grantfox-oss

    🦊 GrantFox — @xJeffx23 has been assigned to this issue as part of the Official Campaign campaign!

    Next steps:

    1. Open a Pull Request referencing this issue (e.g., Closes #18)
    2. Your PR will be reviewed by the ShadeProtocol maintainers

    Good luck! Track your progress on GrantFox.

  4. grantfox-oss commented on Jun 24, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign campaign!

    @xJeffx23's PR #25 was approved and merged by @codebestia.

    🏆 @xJeffx23: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (191 total points). Track your full progress on GrantFox.

    👏 Great work, @xJeffx23! Keep contributing to ShadeProtocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions