Repository navigation
Implement SwapPayment model #41
Description
Represents a swap-routed payment where the payer pays in one token and the merchant settles in another. Specific to Shade's cross-asset capabilities.
Proposed Steps:
- Create
src/shade/models/swap.py. - Fields:
id,pay_in_token,settle_out_token,amount_in: Decimal,amount_out: Optional[Decimal],routing_path: list[str],slippage_tolerance: float,status,stellar_tx_hash: Optional[str],created_at. - Add
SwapStatusenum:pending,swapping,completed,failed,slippage_exceeded. - Validate
0 < slippage_tolerance < 1.
Acceptance Criteria:
SwapPayment.from_dict(...)populates all fields including routing path list.slippage_toleranceoutside(0, 1)raisesValueError.statusis aSwapStatusenum.
Activity
GBOYEE commentedon Jul 20, 2026
Greetings, I can handle this one. I'll implement it to spec and add tests. I'll open a PR referencing this shortly once assigned.
sainath5001 commentedon Jul 20, 2026
Hi, I would like to work on this issue.
I have worked on similar tasks before involving payment flows, token-based transactions, and model/schema implementations with validation logic. I’m familiar with designing data models, enums, serialization/deserialization (
from_dictpatterns), and handling validation constraints.I can implement the SwapPayment model, SwapStatus enum, and required validations according to the acceptance criteria.
ALIPHATICHYD commentedon Jul 20, 2026
Hi maintainer
I'd love to work on this issue
I have defi experience on this aspect
grantfox-oss commentedon Jul 21, 2026
🦊 GrantFox — @ALIPHATICHYD has been assigned to this issue as part of the Official Campaign | FWC26 campaign!
Next steps:
Closes #41)Good luck! Track your progress on GrantFox.
fix(models): address CodeRabbit review on SwapPayment (ShadeProtocol#41)
Merge pull request #46 from ALIPHATICHYD/feature/41-swap-payment-model
grantfox-oss commentedon Jul 27, 2026
🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign | FWC26 campaign!
@ALIPHATICHYD's PR #46 was approved and merged by @codebestia.
🏆 @ALIPHATICHYD: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (254 total points). Track your full progress on GrantFox.
👏 Great work, @ALIPHATICHYD! Keep contributing to ShadeProtocol.
feat(models): add SwapPayment model and SwapStatus enum (ShadeProtoco…