Reduce arena preparation memory spikes - #117
Open
GerwinVerkerk wants to merge 1 commit into
Open
GerwinVerkerk wants to merge 1 commit into
GerwinVerkerk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Stream arena blocks lazily during preparation instead of first allocating a
List<Location>containing every block in the arena.For a 1000 x 100 x 1000 arena, the previous implementation attempted to create 100 million
Locationobjects before the per-tick preparation task began. That creates a large, immediate heap spike inGameRegion#getBlocks()and can freeze or exhaust the server before rollback logging has made progress.This change:
GameRegion;PrepareArenaTaskconsume blocks directly at the configured per-tick rate;This removes the eager location-list allocation reported in #113. Rollback itself can still retain many
BlockStatesnapshots for very large arenas; changing that storage model is a separate architectural concern and is intentionally outside this PR.Verification
./gradlew buildgit diff --checkTarget Minecraft Versions: all currently supported versions
Requirements: none
Related Issues: #113
Checklist before requesting a review
Worked on by