Skip to content

homepage back to the YouTube video only, and a PR check that the site ships every file it names - #505

Merged
gerardrecinto merged 1 commit into
masterfrom
both-videos
Oct 5, 2026
Merged

gerardrecinto merged 1 commit into
masterfrom
both-videos

Conversation

@gerardrecinto

Copy link
Copy Markdown
Collaborator

The live homepage showed a black box where the 43 second video should be. The deploy copies a hard-coded list of assets (one gif), so the video and its posters were never published, while the page was. The local tests did not catch it because they assemble the site a different way, and the deploy's own reference check ignored poster attributes and paths written in scripts.

What changes:

  • The homepage returns to the YouTube intro video and the earlier hero example. The local MP4s, posters and the promo generator are removed (the generator stays in the history of a 43 second demo video built from the real binary, in the hero #502).
  • scripts/assemble-site.sh assembles the site exactly as the deploy does and fails on a missing file named by src, href, poster or a ./assets path in a script. It also fails on any
  • deploy-demo.yml runs that script. It now also copies all of docs/assets and triggers on any change there.
  • New workflow Site Check runs the same script on pull requests that touch the site, as the check Site assembles with every referenced file.

I ran the script locally on the real tree (passes) and on a missing file, an empty MP4, a non-image poster and a local video tag (each fails). I did not get the Playwright suite to run locally: the test web server timed out twice, though it starts fine on its own. The restored homepage tests are the ones that passed before #502.

Not done: Site Check is not a required check yet. That is a branch protection change for you to decide.

Thanks, Gerard Recinto

… ships every file it names

The deploy copied one hard-coded asset, so the live page pointed at video
files that were never published. Videos are YouTube embeds only now. The
deploy and a new PR check run one script that assembles the site and fails
on a missing file or any local video.

Thanks, Gerard Recinto
@gerardrecinto gerardrecinto self-assigned this Oct 5, 2026
@gerardrecinto
gerardrecinto enabled auto-merge (squash) October 5, 2026 16:43
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

Gemini PR Review

Reviewed commit: b23bbff384fb3c1b103ce426851c77e49b6234f8
Verdict: PASS

Here's an evaluation of the diff:

  • Correctness Bug / Unhandled Edge Case Prevention: The new scripts/assemble-site.sh script, run by both the deploy-demo.yml and the new site-check.yml workflows, includes comprehensive checks for all local assets referenced by src, href, or poster attributes (and assets/ paths in scripts) in index.html, agents/index.html, and docs/index.html. It also explicitly disallows local video files (<video> tags or .mp4|.webm|.mov files), enforcing the use of YouTube embeds. This directly addresses and prevents the historical issue of a homepage being deployed with missing video files or broken asset links, significantly improving site integrity.
  • Weakened Tests (resolved by new test): The removal of existing tests related to the local demo video (e.g., the demo video is in the hero..., the demo video plays when it is on screen...) would be a weakening if not replaced. However, a new test intro video sits below the hero and autoplays muted is added in tests/homepage.spec.ts to cover the new YouTube embed behavior, maintaining test coverage for the video functionality.

@gerardrecinto
gerardrecinto merged commit 60edc1d into master Oct 5, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant