Repository navigation
homepage back to the YouTube video only, and a PR check that the site ships every file it names - #505
Merged
Merged
Conversation
… ships every file it names The deploy copied one hard-coded asset, so the live page pointed at video files that were never published. Videos are YouTube embeds only now. The deploy and a new PR check run one script that assembles the site and fails on a missing file or any local video. Thanks, Gerard Recinto
gerardrecinto
enabled auto-merge (squash)
October 5, 2026 16:43
Gemini PR ReviewReviewed commit: Here's an evaluation of the diff:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live homepage showed a black box where the 43 second video should be. The deploy copies a hard-coded list of assets (one gif), so the video and its posters were never published, while the page was. The local tests did not catch it because they assemble the site a different way, and the deploy's own reference check ignored poster attributes and paths written in scripts.
What changes:
I ran the script locally on the real tree (passes) and on a missing file, an empty MP4, a non-image poster and a local video tag (each fails). I did not get the Playwright suite to run locally: the test web server timed out twice, though it starts fine on its own. The restored homepage tests are the ones that passed before #502.
Not done: Site Check is not a required check yet. That is a branch protection change for you to decide.
Thanks, Gerard Recinto