Repository navigation
test that nothing covers the homepage hero when the icon CDN is unreachable - #508
Merged
Merged
Conversation
…chable The boot overlay used to stay up for good if the icon script failed to load, which left the homepage a black screen that still returned 200. This blocks unpkg.com and checks the headline is the topmost element at its own position. It fails on the homepage from before #507.
gerardrecinto
force-pushed
the
site-check-icon-cdn-down
branch
from
October 5, 2026 22:15
079daf7 to
f685097
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| test('nothing covers the hero when the icon CDN is unreachable', async ({ page }) => { | ||
| // The boot overlay once stayed up for good after the icon script failed to load, | ||
| // and the homepage was a black screen that still answered 200. | ||
| await page.route(/unpkg\.com/, (route) => route.abort()); |
Gemini PR ReviewReviewed commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The homepage was a black screen for about 9 hours. The full-screen boot overlay was only removed after the icon script and the WASM engine started in order. When the icon library failed to load, startup threw before the engine started and the overlay stayed up. The page still returned 200, so nothing flagged it. #507 fixed the startup order and scoped the overlay.
This adds a Playwright test to the homepage suite. It blocks
unpkg.com, loads the page, and checks theh1is the topmost element at its own position. It runs in the existing E2E workflow on every PR that touchesdemo/**.Checked locally in chromium: it passes on current master and fails on the homepage from before #507 (headline covered).
This does not watch the live site after a deploy. A post-deploy check against joltrinhq.com would be a separate change.
Thanks, Gerard Recinto