Repository navigation
flatten blocklog Stats maps and add the README videos - #509
Merged
Merged
Conversation
Gemini PR ReviewReviewed commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes.
README: the full demo and the short now show as clickable YouTube thumbnails under the demo GIF.
blocklog: Stats built a nested map for every rule and trace pair. It now uses flat maps with the per-run counts held by value. Same results, and the existing blocklog tests pass with -race. BenchmarkStats on the 5000-entry log, before and after:
time 1.97 ms to 1.42 ms
allocs 10095 to 128
memory 3.2 MB to 2.66 MB
verify was already at about 40 ns with 0 allocs on the safety check, so I left it alone.