Skip to content

ditch the pr-quality-gate skill, nothing references it - #512

Merged
gerardrecinto merged 1 commit into
masterfrom
remove-pr-quality-gate
Oct 8, 2026
Merged

gerardrecinto merged 1 commit into
masterfrom
remove-pr-quality-gate

Conversation

@gerardrecinto

Copy link
Copy Markdown
Collaborator

Removes .claude/skills/pr-quality-gate. Nothing else in the repo points at it: no workflow, doc, or CLAUDE.md names it, and it was the only skill under .claude/skills, so the directory goes too. CI is unaffected.

Thanks, Gerard Recinto

@gerardrecinto gerardrecinto self-assigned this Oct 8, 2026
@gerardrecinto
gerardrecinto enabled auto-merge (squash) October 8, 2026 08:41
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Gemini PR Review

Reviewed commit: 7dd1a2d29c9f349f1778ced6dc996ecc873b90df
Verdict: FAIL

  • PM: The file .claude/skills/pr-quality-gate/SKILL.md, which defines the process and guidelines for the "pr-quality-gate" Claude AI skill, has been deleted. Without a pull request description to clarify the intent, this raises concerns under the Technical PM lens regarding potential inconsistencies in the PR review process or the operational guidelines for the AI assistant, should the skill still be active.

This result blocks merge. Push a fix and comment /gemini review. To contest a finding, see the Gemini dispute process in CONTRIBUTING.md.

@gerardrecinto

Copy link
Copy Markdown
Collaborator Author

/gemini dispute

  1. Finding, quoted: "The file .claude/skills/pr-quality-gate/SKILL.md ... has been deleted. Without a pull request description to clarify the intent, this raises concerns under the Technical PM lens regarding potential inconsistencies in the PR review process or the operational guidelines for the AI assistant, should the skill still be active."

  2. Where: .claude/skills/pr-quality-gate/SKILL.md, deleted in full. Nothing else in the diff.

  3. Claim status: Inferred and conditional ("should the skill still be active"). It names no broken reference.

  4. Evidence: on master before this change, grep -rIn pr-quality-gate . outside the skill own directory returned nothing. No workflow, doc, README, CONTRIBUTING.md, CLAUDE.md or script refers to it, and .claude/skills/ held only this one skill. The PR review process in this repo is the Gemini gate, claude-review.yml, CodeQL, Trivy and Gitleaks, all unchanged. The PR does have a description stating the intent.

  5. Official docs: not applicable, this is a local Claude Code skill file, not an input to the build or CI.

  6. Reachability: none. The file is only read when someone invokes the skill by name in a local Claude Code session.

  7. Repro: git grep -n pr-quality-gate origin/master lists only the skill own files.

  8. Compensating control: all required checks pass on this branch (Sanity on three OSes, Site Check, Build & Test, CodeQL, Trivy, Gitleaks).

  9. Resolution requested: treat as not applicable.

@gerardrecinto

Copy link
Copy Markdown
Collaborator Author

/gemini review

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Gemini PR Review

Reviewed commit: 7dd1a2d29c9f349f1778ced6dc996ecc873b90df
Verdict: PASS

  • The dispute regarding the deletion of .claude/skills/pr-quality-gate/SKILL.md is addressed. The evidence provided indicates that this file is a local Claude skill description, not referenced by any other part of the codebase, CI/CD, or documentation. It appears to be an unused or deprecated local tool description. Its deletion does not introduce security problems, correctness bugs, races, leaks, unhandled edge cases, or weaken existing tests in the Go and Java codebase. The claim that the PR description clarifies intent further supports this. The original finding is withdrawn.

@gerardrecinto
gerardrecinto merged commit a5a65bf into master Oct 8, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant