Repository navigation
homepage and arena a11y: readable small text, a labeled close button, heading order, bigger phone tabs - #517
Merged
Merged
Conversation
… heading order, bigger phone tabs
gerardrecinto
enabled auto-merge (squash)
October 8, 2026 09:37
Collaborator
Author
|
/gemini review |
Collaborator
Author
|
/gemini review |
Gemini PR ReviewReviewed commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran a script over the built homepage on desktop and phone sizes (WCAG contrast of every text node against its real background, tap target sizes, heading order, button names, image alt) and fixed what it found. No copy was changed.
Small gray text used Tailwind slate-500 at 4.0:1 on the dark panels, under the 4.5:1 that 11 to 12 px text needs. 18 text nodes on the homepage failed. Both Tailwind configs now map slate-500 to #808fa5 (5.4:1 or better on every panel color), which fixes every use at once. The two terminal placeholder lines were 1.9:1 and now use that color. The Pro checkout modal close button was an icon with no label, so a screen reader announced just button; it has aria-label=Close and type=button. The homepage had two h2 followed by h4 jumps and the arena had h1 to h3 and h2 to h4; heading tags changed with their classes untouched, so nothing moves on screen. On phones the two scenario tabs were 30 px tall and are now 44 px (desktop is unchanged).
After the change the same script reports 0 low contrast text nodes from slate, 0 unlabeled buttons, and 0 heading skips on the homepage, and the arena sequence is h1, h2, h3 throughout. The audit also flagged black text on the green gradient buttons; that was my script reading a gradient as no background, and the contrast there is fine.
The two accessible-name and heading-order checks are now part of site-smoke.spec.ts, so they run on all four pages in the required Site Check from here on. Full e2e passes on chromium, webkit and mobile-chrome.
Still open: two 12 px violet labels sit at 4.1 to 4.2:1, and a few inline text links on phones are 15 to 20 px tall. The headline and positioning copy I left alone, since changing those is your call.
Thanks, Gerard Recinto