Skip to content

馃悰 fix: match identical bypass comments consistently - #8

Merged
SigureMo merged 1 commit into
mainfrom
codex/fix-comment-pattern-state
Oct 1, 2026
Merged

SigureMo merged 1 commit into
mainfrom
codex/fix-comment-pattern-state

Conversation

@SigureMo

@SigureMo SigureMo commented Oct 1, 2026

Copy link
Copy Markdown

When someone outside the CI team posts /bypass ci before a CI member posts the same command, the shared global regex retains lastIndex and can skip the authorized comment. Compile comment patterns without the g flag so each comment is matched independently, and rebuild dist/index.js.

Validation:

  • vp test: all 31 existing tests passed.
  • vp check: formatting, lint, and type checks passed.
  • vp pack: bundled JavaScript rebuilt successfully.
  • Executed the original and rebuilt bundles against a local mock GitHub API. The outsider-then-member sequence changes from incorrectly rejecting the bypass to accepting it; member-first, outsider-only, and member-only controls retain their expected results.
This PR is co-authored with @codex (gpt-6 astra xhigh)

Co-authored-by: Codex <noreply@openai.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

@SigureMo
SigureMo merged commit abb6a4f into main Oct 1, 2026
8 checks passed
@SigureMo
SigureMo deleted the codex/fix-comment-pattern-state branch October 1, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant