🏷️ types: move to ty by Copilot · Pull Request #75 · ShigureLab/watchfs

Copilot · 2026-04-25T18:54:57Z

Summary

replace pyright with ty in the dev dependency set, lockfile, and lint command
remove the old Pyright config, remove the Pylance recommendation/workspace settings, and recommend the ty VS Code extension
fix the small typing issues that ty --error-on-warning surfaced so local lint, tests, and build stay green

Validation

uv run ruff format --check .
npx --yes prettier --check '**/*.md'
uv run ty check --error-on-warning src/watchfs tests
uv run ruff check .
uv run pytest --reruns 3 --reruns-delay 1
uv build

Agent-Logs-Url: https://github.com/ShigureLab/watchfs/sessions/58f1d339-3811-4f7b-93e3-e13db85f0dce Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>

SigureMo · 2026-04-25T18:56:29Z

@@ -2,6 +2,7 @@
  "recommendations": [
    "ms-python.python",
    "ms-python.vscode-pylance",


@copilot pylance 肯定得删掉啊！

已删掉 Pylance 推荐，并顺手去掉了对应的 workspace python.analysis.* 设置，避免配置不一致。commit: 92b2d10

SigureMo · 2026-04-25T19:01:04Z

+type ExceptionHook = Callable[[type[BaseException], BaseException, TracebackType | None], object]
+
+oldHook: ExceptionHook = sys.excepthook
+
+
+def handle_uncaught_exception(
+    exctype: type[BaseException], exception: BaseException, trace: TracebackType | None
+) -> None:
    oldHook(exctype, exception, trace)
    if isinstance(exception, WatchFsBaseException):
-        sys.exit(exception.code.value)
+        raise SystemExit(exception.code.value)


-sys.excepthook, oldHook = handleUncaughtException, sys.excepthook
+sys.excepthook = handle_uncaught_exception


@copilot yutto 那边也没这么写啊，为啥这个要改成这样？

这里已经改回更接近原来那版的写法了：保留 handleUncaughtException / oldHook 这套结构，只补了让 ty 通过所需的参数类型和返回类型。commit: 92b2d10

Agent-Logs-Url: https://github.com/ShigureLab/watchfs/sessions/d42dbe9d-7495-4032-976f-a69bc166bf33 Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>

SigureMo · 2026-04-25T19:13:14Z



-def handleUncaughtException(exctype: type[Exception], exception: Exception, trace: TracebackType):
+def handleUncaughtException(


Suggested change

def handleUncaughtException(

def handle_uncaught_exception(

已按建议改成 snake_case。commit: 4efc436

SigureMo · 2026-04-25T19:13:21Z

+def handleUncaughtException(
+    exctype: type[BaseException], exception: BaseException, trace: TracebackType | None
+) -> None:
    oldHook(exctype, exception, trace)


Suggested change

oldHook(exctype, exception, trace)

old_hook(exctype, exception, trace)

已改成 old_hook。commit: 4efc436

SigureMo · 2026-04-25T19:13:35Z

+oldHook = sys.excepthook
+sys.excepthook = handleUncaughtException


@copilot 写回一行

已经写回一行了。commit: 4efc436

Agent-Logs-Url: https://github.com/ShigureLab/watchfs/sessions/370ffd1c-7142-4d31-81e8-075ab705e7a2 Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>

Copilot

Pull request overview

This PR migrates the repo’s type-checking workflow from Pyright to ty, updates the dev toolchain configuration accordingly, and includes a few small code tweaks to satisfy stricter typing checks.

Changes:

Replace pyright with ty across dev dependencies, lockfile, and just lint command.
Remove Pyright-specific configuration and adjust VS Code recommendations/settings.
Minor typing-driven refactors (sync wrapper for subprocess.run, explicit “unreachable” marker, exception hook typing cleanup, remove a type: ignore import).

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
uv.lock	Drops `pyright`/`nodeenv`, adds `ty` to the locked dev dependency set.
pyproject.toml	Replaces `pyright` with `ty` in dev deps; removes `[tool.pyright]`; adjusts Ruff ignores.
justfile	Updates lint command to `ty check --error-on-warning`.
.vscode/settings.json	Removes Pylance type-checking/inlay-hints settings.
.vscode/extensions.json	Recommends `astral-sh.ty` and drops `ms-python.vscode-pylance`.
src/watchfs/targets.py	Introduces `_run_command_sync` wrapper and uses `capture_output` for typing clarity.
src/watchfs/mappings.py	Adds an explicit unreachable marker after structural pattern matching.
src/watchfs/exceptions.py	Renames/retokens excepthook handler, improves typing, uses `SystemExit`.
src/watchfs/main.py	Removes `# type: ignore` on `watchfiles` import.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-25T19:19:44Z

  "recommendations": [
    "ms-python.python",
-    "ms-python.vscode-pylance",
+    "astral-sh.ty",
    "charliermarsh.ruff",
    "esbenp.prettier-vscode",


PR description says to keep Pylance for editor inlay hints, but this change removes the ms-python.vscode-pylance recommendation entirely. Either re-add the Pylance extension here, or update the PR description to match the intended editor setup (and ensure inlay hints are still enabled somewhere if that’s desired).

Copilot · 2026-04-25T19:19:45Z

 {
  "python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python",
-  "python.analysis.typeCheckingMode": "strict",
-  "python.analysis.inlayHints.functionReturnTypes": true,
-  "python.analysis.inlayHints.variableTypes": true,
  "[python]": {
    "editor.defaultFormatter": "charliermarsh.ruff"
  }


PR description mentions keeping Pylance for inlay hints, but these settings removed the explicit inlay-hint options (and strict typeCheckingMode). If inlay hints are still intended as part of the recommended setup, consider keeping the inlay-hint settings (or documenting the new defaults) so contributors get consistent editor behavior.

🏷️ types: move to ty

3c95ecc

Agent-Logs-Url: https://github.com/ShigureLab/watchfs/sessions/58f1d339-3811-4f7b-93e3-e13db85f0dce Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>

Copilot AI assigned Copilot and SigureMo Apr 25, 2026

Copilot created this pull request from a session on behalf of SigureMo April 25, 2026 18:55 View session

Copilot AI requested a review from SigureMo April 25, 2026 18:55

Copilot finished work on behalf of SigureMo April 25, 2026 18:55

SigureMo requested changes Apr 25, 2026

View reviewed changes

Copilot started work on behalf of SigureMo April 25, 2026 19:01 View session

Copilot AI and others added 2 commits April 25, 2026 19:03

fix review feedback on ty migration

92b2d10

Agent-Logs-Url: https://github.com/ShigureLab/watchfs/sessions/d42dbe9d-7495-4032-976f-a69bc166bf33 Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>

refine exception hook typing

832f998

Agent-Logs-Url: https://github.com/ShigureLab/watchfs/sessions/d42dbe9d-7495-4032-976f-a69bc166bf33 Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>

Copilot finished work on behalf of SigureMo April 25, 2026 19:05

Copilot AI requested a review from SigureMo April 25, 2026 19:05

SigureMo requested changes Apr 25, 2026

View reviewed changes

Copilot started work on behalf of SigureMo April 25, 2026 19:13 View session

apply latest exception hook review suggestions

4efc436

Agent-Logs-Url: https://github.com/ShigureLab/watchfs/sessions/370ffd1c-7142-4d31-81e8-075ab705e7a2 Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>

SigureMo approved these changes Apr 25, 2026

View reviewed changes

SigureMo marked this pull request as ready for review April 25, 2026 19:16

Copilot AI review requested due to automatic review settings April 25, 2026 19:16

fix exception hook tuple assignment order

326cee1

Agent-Logs-Url: https://github.com/ShigureLab/watchfs/sessions/370ffd1c-7142-4d31-81e8-075ab705e7a2 Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>

Copilot started reviewing on behalf of SigureMo April 25, 2026 19:16 View session

SigureMo merged commit a10feef into main Apr 25, 2026
4 checks passed

Copilot finished work on behalf of SigureMo April 25, 2026 19:17

Copilot AI requested a review from SigureMo April 25, 2026 19:17

SigureMo deleted the copilot/move-to-ty branch April 25, 2026 19:19

Copilot AI reviewed Apr 25, 2026

View reviewed changes



		def handleUncaughtException(exctype: type[Exception], exception: Exception, trace: TracebackType):
		def handleUncaughtException(

	oldHook(exctype, exception, trace)
	old_hook(exctype, exception, trace)

		oldHook = sys.excepthook
		sys.excepthook = handleUncaughtException

Uh oh!

Conversation

Copilot AI commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

SigureMo Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

SigureMo Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

SigureMo Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

SigureMo Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

SigureMo Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 25, 2026 •

edited

Loading