support bundle folder in the bundle ui step config#7340
Merged
alfonso-noriega merged 2 commits intomainfrom Apr 22, 2026
Merged
support bundle folder in the bundle ui step config#7340alfonso-noriega merged 2 commits intomainfrom
alfonso-noriega merged 2 commits intomainfrom
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alfonso-noriega
force-pushed
the
04-17-support_bundle_folder_in_the_bundle_ui_step_config
branch
from
b707dea to
da8fec7
Compare
vividviolet
approved these changes
Apr 20, 2026
Member
vividviolet
left a comment
vividviolet
left a comment
There was a problem hiding this comment.
Tophat'd - it's all working. Just need to add some tests
alfonso-noriega
force-pushed
the
04-17-support_bundle_folder_in_the_bundle_ui_step_config
branch
from
da8fec7 to
7718c51
Compare
alfonso-noriega
force-pushed
the
04-17-support_bundle_folder_in_the_bundle_ui_step_config
branch
from
7718c51 to
ffa8ebe
Compare
isaacroldan
reviewed
Apr 21, 2026
Comment on lines
+70
to
+73
| const buildDirectory = options.buildDirectory ?? '' | ||
|
|
||
| // Always build into the extension's local directory (e.g. ext/dist/handle.js) | ||
| const localOutputPath = joinPath(extension.directory, extension.outputRelativePath) | ||
| const localOutputPath = joinPath(extension.directory, buildDirectory, extension.outputRelativePath) |
Contributor
There was a problem hiding this comment.
Does this buildDirectory includes the value of bundleFolder? :thinking_face:
I'm missing how this is connected
isaacroldan
approved these changes
Apr 21, 2026
4 tasks
alfonso-noriega
deleted the
04-17-support_bundle_folder_in_the_bundle_ui_step_config
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add