Extend global config directive to accept pattern specifiers - #1035
Open
juniper-shopify wants to merge 1 commit into
Open
Extend global config directive to accept pattern specifiers#1035juniper-shopify wants to merge 1 commit into
juniper-shopify wants to merge 1 commit into
Conversation
juniper-shopify
force-pushed
the
juniper/global-config-specifiers
branch
from
July 17, 2026 21:47
eea4c12 to
7885b6c
Compare
juniper-shopify
force-pushed
the
juniper/global-config-specifiers
branch
3 times, most recently
from
July 17, 2026 21:54
6a362d5 to
635c9d5
Compare
juniper-shopify
changed the title
juniper-shopify
marked this pull request as ready for review
July 17, 2026 21:59
juniper-shopify
requested review from
dersam,
mathiusj and
nfgrep
as code owners
July 17, 2026 21:59
juniper-shopify
force-pushed
the
juniper/global-config-specifiers
branch
from
July 17, 2026 22:01
635c9d5 to
b589675
Compare
Allow `global(:step_name)` and `global(/pattern/)` in Roast config blocks,
mirroring the existing name/pattern specifier support in cog-type blocks
(agent, chat, cmd, etc.).
This enables targeted cross-cutting configuration like:
global(:my_step) { async! }
global(/^api_/) { abort_on_failure! }
The merge cascade expands from 4 tiers to 7:
1. global (bare)
2. global (regexp match)
3. global (exact name)
4. cog-type general
5. cog-type regexp match
6. cog-type exact name
7. inline YAML
Also cleans up a vestigial `instance_variable_get(:@values)` call
to use the public `.values` accessor instead.
juniper-shopify
force-pushed
the
juniper/global-config-specifiers
branch
from
July 17, 2026 22:02
b589675 to
519635c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the
globalconfig directive to accept optional pattern specifiers, mirroring the existing support in cog-type blocks (agent,chat,cmd, etc.).Note: name-specific specifiers are not implemented, only patterns. Cog names must be unique across all cog types, so there's no reason to use a name-specific global block.
Motivation
Currently,
global { ... }can be used to apply certain high-level configuration parameters to every cog unconditionally. Regexp matchers can be used to apply configuration to groups of cogs of a single type. But when cogs of multiple different types exist in a logical group, there is no way to apply common configuration to all of them in a single block.This feature enables: