Fix nullability of GraphQL scalar types when passed as required arguments#2618
Open
joeytepp wants to merge 1 commit into
Open
Fix nullability of GraphQL scalar types when passed as required arguments#2618joeytepp wants to merge 1 commit into
joeytepp wants to merge 1 commit into
Conversation
…ents Currently, the generated rbis for a GraphQL mutation that contains an argument that uses a scalar type will always treat the argument as nullable, even when it is required. This PR fixes it so that required arguments are treated as non-nullable.
Author
|
I have signed the CLA! |
KaanOzkan
reviewed
May 11, 2026
| return_type = signature&.return_type | ||
|
|
||
| valid_return_type?(return_type) ? return_type.to_s : "T.untyped" | ||
| valid_return_type?(return_type) ? RBIHelper.as_non_nilable_type(return_type.to_s) : "T.untyped" |
Contributor
There was a problem hiding this comment.
Can you give context on why we can assume coerce_input can't return nil?
Author
There was a problem hiding this comment.
coerce_input has to handle both required and optional arguments, and for an optional argument it still gets called with an input of nil. So when we have a required argument the signature should no longer have a T.nilable(...) since we know the output won't be nil.
Contributor
There was a problem hiding this comment.
Let's capture this in a comment since there's quite a bit going on, something like
# Wrap as non-nilable for required arguments. `coerce_input` supports both
# required and optional; optional arguments are re-wrapped below based on `type.non_null?`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2337
Currently, the generated rbis for a GraphQL mutation that contains an argument that uses a scalar type will always treat the argument as nullable, even when it is required. This PR fixes it so that required arguments are treated as non-nullable.
Implementation
Updated
GraphQLTypeHelperto useRBIHelper.as_non_nilable_typein the current branch of logic.Tests
Added a new test in
spec/tapioca/dsl/compilers/graphql_mutation_spec.rb