Repository navigation
Optimistically shallow clone submodules - #39
Merged
Merged
Conversation
Contributor
Author
|
Clearing |
In chonky repos like grpc, full clones of submodules can take on the order of ~3 minutes. Shallow cloning should help though I haven't benchmarked this yet. In order to avoid changing observable behaviour, we fall back to a regular clone so if someone was shallow cloning a repo with submodules, and the submodule was coming from a forge that doesn't allow cloning of a specific sha, the existing cloning behaviour should be preserved.
joshheinrichs-shopify
force-pushed
the
shallow-submodules
branch
from
October 8, 2026 18:07
3531a04 to
3478a17
Compare
joshheinrichs-shopify
marked this pull request as ready for review
October 8, 2026 18:24
jacobmichels
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In chonky repos like grpc, full clones of submodules can take on the order of ~3 minutes. Shallow cloning should help though I haven't benchmarked this yet. In order to avoid changing observable behaviour, we fall back to a regular clone so if someone was shallow cloning a repo with submodules, and the submodule was coming from a forge that doesn't allow cloning of a specific sha, the existing cloning behaviour should be preserved.
Motivation
Context