Skip to content

Port pf/print bug fixes (PSI #1637)#121

Merged
jd-lara merged 1 commit into
mainfrom
ac/pf-print-bugs
Jun 24, 2026
Merged

Port pf/print bug fixes (PSI #1637)#121
jd-lara merged 1 commit into
mainfrom
ac/pf-print-bugs

Conversation

@acostarelli

Copy link
Copy Markdown
Member
  • compute_conflict!: header -> column_labels for PrettyTables v3
  • docs.yml: add docs-deploy concurrency group

Thanks for opening a PR to InfrastructureOptimizationModels.jl, please take note of the following when making a PR:

Check the contributor guidelines

- compute_conflict!: header -> column_labels for PrettyTables v3
- docs.yml: add docs-deploy concurrency group

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@acostarelli acostarelli requested a review from Copilot June 23, 2026 15:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Ports PrettyTables keyword changes and refines GitHub Actions docs workflow execution behavior.

Changes:

  • Updated compute_conflict! PrettyTables call to use column_labels (PrettyTables v3).
  • Added a workflow-level concurrency group for docs builds/deployments.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/core/optimization_container.jl Updates PrettyTables keyword for v3 compatibility when printing conflicts.
.github/workflows/docs.yml Adds concurrency settings intended to control overlapping docs runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +11 to +13
concurrency:
group: docs-deploy
cancel-in-progress: false
@github-actions

Copy link
Copy Markdown
Contributor

Performance Results
Main

Network: 10 nodes, 13 edges, 3 cost segments
Generators: 5, Demands: 5
Loss coefficients (a, b, c) per generator:
  n1: a=0.007287  b=0.005968  c=0.003850
  n2: a=0.001094  b=0.009002  c=0.007028
  n3: a=0.007897  b=0.008552  c=0.003001
  n4: a=0.008179  b=0.002530  c=0.009637
  n5: a=0.009778  b=0.009934  c=0.009099

Solver logs: /home/runner/work/InfrastructureOptimizationModels.jl/InfrastructureOptimizationModels.jl/main/test/performance/logs/solver_2026-06-23T15-35-10.log

==============================================================================================================================================
Bilinear Approximation Benchmarks
  Refinement = depth for all methods
==============================================================================================================================================
Method          R   Vars Constrs   Bins    Objective   Gap(%) MIPGap(%)     LowerBnd  rmse δbi   max δbi   rmse δq    max δq  build_t  solve_t
----------------------------------------------------------------------------------------------------------------------------------------------
NLP (Ipopt)     -     40     105      0     0.956760        -         -            -  0.00e+00  0.00e+00  0.00e+00  0.00e+00   0.0333   0.0048

NLP (Uno)       -     40     105      0     0.956760   0.0000         -            -  0.00e+00  0.00e+00  0.00e+00  0.00e+00   0.0016   0.0059

Bin2+sSOS       4    190     535      0     1.180700  23.4061    0.0000     1.180700  8.07e-02  1.41e-01  2.49e+01  5.48e+01   0.0069   1.8841
Bin2+sSOS       6    250     655      0     1.098175  14.7806    0.0000     1.098175  1.26e-01  2.86e-01  5.47e+00  9.07e+00   0.0067   7.9207
Bin2+sSOS       8    310     775      0     1.053069  10.0661    0.0088     1.052976  8.62e-02  2.43e-01  4.18e+01  9.32e+01   0.0065  28.0610

Bin2+mSOS       4    310     805    120     1.180700  23.4061    0.0000     1.180700  8.07e-02  1.41e-01  2.49e+01  5.48e+01   0.0025   1.8437
Bin2+mSOS       6    430    1045    180     1.098175  14.7806    0.0000     1.098175  1.26e-01  2.86e-01  5.47e+00  9.07e+00   0.0026   6.0561
Bin2+mSOS       8    550    1285    240     1.053069  10.0661    0.0080     1.052984  8.62e-02  2.43e-01  4.18e+01  9.32e+01   0.0027  20.1765

Bin2+Saw        4    310    1075    120     0.985859   3.0414    0.0055     0.985805  1.15e-01  2.48e-01  2.65e+02  5.18e+02   0.0033  12.2697
Bin2+Saw        6    430    1495    180     0.958677   0.2004    0.0077     0.958603  7.52e-02  1.68e-01  8.94e+01  1.71e+02   0.0040  14.2898
Bin2+Saw        8    550    1915    240     0.956996   0.0247    0.0072     0.956927  7.52e-02  1.68e-01  1.37e+02  2.09e+02   0.0046  52.8816

HybS+sSOS       4    310    1165      0     0.812261  15.1030    0.0000     0.812261  5.52e-01  1.00e+00  2.04e+02  2.97e+02   0.0073   2.8696
HybS+sSOS       6    410    1545      0     0.891208   6.8515    0.0000     0.891208  5.49e-01  1.00e+00  3.69e+02  7.09e+02   0.0076   5.1303
HybS+sSOS       8    510    1925      0     0.934789   2.2965    0.0087     0.934707  5.48e-01  1.00e+00  3.47e+02  5.22e+02   0.0084  16.3314

HybS+mSOS       4    390    1345     80     0.812261  15.1030    0.0046     0.812224  5.52e-01  1.00e+00  2.04e+02  2.97e+02   0.0035   3.0322
HybS+mSOS       6    530    1805    120     0.891208   6.8515    0.0000     0.891208  5.49e-01  1.00e+00  3.69e+02  7.09e+02   0.0040   6.5512
HybS+mSOS       8    670    2265    160     0.934789   2.2965    0.0047     0.934744  5.48e-01  1.00e+00  3.47e+02  5.22e+02   0.0045  16.8573

HybS+Saw        4    390    1525     80     0.951869   0.5113    0.0084     0.951789  5.48e-01  1.00e+00  2.16e+03  4.23e+03   0.0040  11.0545
HybS+Saw        6    530    2105    120     0.956386   0.0391    0.0099     0.956291  5.48e-01  1.00e+00  4.57e+02  7.57e+02   0.0050  35.0259
HybS+Saw        8    670    2685    160     0.956734   0.0027    0.0078     0.956659  5.48e-01  1.00e+00  6.08e+00  1.07e+01   0.0058 104.5792

DNMDT           4    395    1640     80     0.954878   0.1967    0.0004     0.954874  1.39e-03  3.13e-03  4.70e-04  1.05e-03   0.0032   4.3056
DNMDT           6    550    2315    120     0.956636   0.0130    0.0098     0.956541  6.75e-05  1.57e-04  4.26e+03  9.54e+03   0.0037  18.5195
DNMDT           8    705    2990    160     0.956754   0.0007    0.0096     0.956662  4.62e-06  1.14e-05  9.42e+01  1.49e+02   0.0044  57.8517

==============================================================================================================================================

This branch

Network: 10 nodes, 13 edges, 3 cost segments
Generators: 5, Demands: 5
Loss coefficients (a, b, c) per generator:
  n1: a=0.007287  b=0.005968  c=0.003850
  n2: a=0.001094  b=0.009002  c=0.007028
  n3: a=0.007897  b=0.008552  c=0.003001
  n4: a=0.008179  b=0.002530  c=0.009637
  n5: a=0.009778  b=0.009934  c=0.009099

Solver logs: /home/runner/work/InfrastructureOptimizationModels.jl/InfrastructureOptimizationModels.jl/branch/test/performance/logs/solver_2026-06-23T15-43-37.log

==============================================================================================================================================
Bilinear Approximation Benchmarks
  Refinement = depth for all methods
==============================================================================================================================================
Method          R   Vars Constrs   Bins    Objective   Gap(%) MIPGap(%)     LowerBnd  rmse δbi   max δbi   rmse δq    max δq  build_t  solve_t
----------------------------------------------------------------------------------------------------------------------------------------------
NLP (Ipopt)     -     40     105      0     0.956760        -         -            -  0.00e+00  0.00e+00  0.00e+00  0.00e+00   0.0335   0.0048

NLP (Uno)       -     40     105      0     0.956760   0.0000         -            -  0.00e+00  0.00e+00  0.00e+00  0.00e+00   0.0015   0.0056

Bin2+sSOS       4    190     535      0     1.180700  23.4061    0.0000     1.180700  8.07e-02  1.41e-01  2.49e+01  5.48e+01   0.0069   1.8884
Bin2+sSOS       6    250     655      0     1.098175  14.7806    0.0000     1.098175  1.26e-01  2.86e-01  5.47e+00  9.07e+00   0.0067   7.9352
Bin2+sSOS       8    310     775      0     1.053069  10.0661    0.0088     1.052976  8.62e-02  2.43e-01  4.18e+01  9.32e+01   0.0068  28.1362

Bin2+mSOS       4    310     805    120     1.180700  23.4061    0.0000     1.180700  8.07e-02  1.41e-01  2.49e+01  5.48e+01   0.0026   1.8437
Bin2+mSOS       6    430    1045    180     1.098175  14.7806    0.0000     1.098175  1.26e-01  2.86e-01  5.47e+00  9.07e+00   0.0027   6.1244
Bin2+mSOS       8    550    1285    240     1.053069  10.0661    0.0080     1.052984  8.62e-02  2.43e-01  4.18e+01  9.32e+01   0.0028  20.3220

Bin2+Saw        4    310    1075    120     0.985859   3.0414    0.0055     0.985805  1.15e-01  2.48e-01  2.65e+02  5.18e+02   0.0034  12.2907
Bin2+Saw        6    430    1495    180     0.958677   0.2004    0.0077     0.958603  7.52e-02  1.68e-01  8.94e+01  1.71e+02   0.0040  14.3336
Bin2+Saw        8    550    1915    240     0.956996   0.0247    0.0072     0.956927  7.52e-02  1.68e-01  1.37e+02  2.09e+02   0.0047  52.8122

HybS+sSOS       4    310    1165      0     0.812261  15.1030    0.0000     0.812261  5.52e-01  1.00e+00  2.04e+02  2.97e+02   0.0087   2.8915
HybS+sSOS       6    410    1545      0     0.891208   6.8515    0.0000     0.891208  5.49e-01  1.00e+00  3.69e+02  7.09e+02   0.0079   5.1538
HybS+sSOS       8    510    1925      0     0.934789   2.2965    0.0087     0.934707  5.48e-01  1.00e+00  3.47e+02  5.22e+02   0.0087  16.3717

HybS+mSOS       4    390    1345     80     0.812261  15.1030    0.0046     0.812224  5.52e-01  1.00e+00  2.04e+02  2.97e+02   0.0035   3.0262
HybS+mSOS       6    530    1805    120     0.891208   6.8515    0.0000     0.891208  5.49e-01  1.00e+00  3.69e+02  7.09e+02   0.0041   6.5834
HybS+mSOS       8    670    2265    160     0.934789   2.2965    0.0047     0.934744  5.48e-01  1.00e+00  3.47e+02  5.22e+02   0.0048  17.0518

HybS+Saw        4    390    1525     80     0.951869   0.5113    0.0084     0.951789  5.48e-01  1.00e+00  2.16e+03  4.23e+03   0.0040  11.1271
HybS+Saw        6    530    2105    120     0.956386   0.0391    0.0099     0.956291  5.48e-01  1.00e+00  4.57e+02  7.57e+02   0.0048  35.3613
HybS+Saw        8    670    2685    160     0.956734   0.0027    0.0078     0.956659  5.48e-01  1.00e+00  6.08e+00  1.07e+01   0.0058 104.9132

DNMDT           4    395    1640     80     0.954878   0.1967    0.0004     0.954874  1.39e-03  3.13e-03  4.70e-04  1.05e-03   0.0032   4.3473
DNMDT           6    550    2315    120     0.956636   0.0130    0.0098     0.956541  6.75e-05  1.57e-04  4.26e+03  9.54e+03   0.1398  18.7254
DNMDT           8    705    2990    160     0.956754   0.0007    0.0096     0.956662  4.62e-06  1.14e-05  9.42e+01  1.49e+02   0.0041  58.4344

==============================================================================================================================================

@jd-lara jd-lara self-requested a review June 24, 2026 00:26
@jd-lara jd-lara merged commit ea6f4af into main Jun 24, 2026
6 of 7 checks passed
@jd-lara jd-lara deleted the ac/pf-print-bugs branch June 24, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants