Repository navigation
fix(paper): prevent server stalls from inventory holder snapshots - #97
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent HeadDB's GUI holder checks from creating unnecessary block entity snapshots during inventory click and close events.
This behavior can be abused to cause a server-wide denial of service, potentially resulting in a watchdog-triggered shutdown.
Root cause
Normal container clicks pass through multiple HeadDB menu handlers, even when the player is not using a HeadDB menu.
These handlers call
Inventory#getHolder()to identify custom menu holders. For block inventories, this creates a block entity snapshot, which serializes and deserializes the container contents. With deeply nested item data, this work can be expensive.