Default to approval always with full-access sandbox and propagate policy uniformly - #42
Merged
Merged
Conversation
…icy uniformly - A no-argument run now equals `--sandbox-profile danger-full-access --approval always`; ask/auto-read/auto-write/never and read-only/workspace-write remain explicit opt-ins. - Resolve approval/sandbox policy once at startup: invalid or non-Unicode DEXT_APPROVAL/DEXT_TRUST warn and fail safe to ask; invalid DEXT_SANDBOX_PROFILE fails startup unless a CLI override wins. - Rework --eval parsing (flag plus one optional case name, conflicts rejected) and run the eval harness, hooks, diagnostics, eval commands, and every pack-runtime event under the selected sandbox profile. - Full-access subprocess launches skip sandbox scratch and preserve ambient temp/cache configuration; confined profiles keep private scratch and native enforcement. - Add a native Windows ConPTY real-binary smoke test (launch, /status default-policy check, clean exit, terminal restoration) with a deadlock-free bounded background output reader; require it in CI and release workflows alongside the Unix PTY suite. - Add regression tests for policy resolution precedence, non-Unicode environment fail-safety, eval CLI forms, always-profile host-operation approval, and the full-access no-scratch fast path. - Update README, SECURITY, CHANGELOG, CONTRIBUTING, docs site, focused guides, and the risk register to the ambient-authority trust model; track first Windows-host CI evidence for the ConPTY harness as open.
…aware timeout diagnostics
… stdio under redirected test capture
…t stall process exit
…op stops with the agent loop
…and sync docs and risk register with Windows ConPTY evidence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushes local commit 98192ed via PR because main requires 3 status checks.