Add option to select activation function for ChamberSphere - #239
Add option to select activation function for ChamberSphere#239charoheijnen wants to merge 4 commits into
Conversation
…y of activation funcitons. Added double_tanh activation funciton to activation function file. Changed chamver_sphere.json test case to be able to choose activaiton function. when double_tanh activation funciton was selected test case runs as previously ran.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
@charoheijnen, it looks like the GUI test is throwing an error:
I think the fix is to bump this up to 24 (or avoid setting a version altogether): svZeroDSolver/.github/workflows/gui.yml Line 22 in ce68a7c |
mrp089
left a comment
mrp089
left a comment
There was a problem hiding this comment.
Great work, @charoheijnen! See below two comments
| generate_block(model, vessel_values, vessel_type, vessel_name); | ||
|
|
||
| // Create and set activation_function for vessel types that use one | ||
| if (vessel_type == "ChamberSphere") { |
There was a problem hiding this comment.
Does the ChamberElastance block not also use an activation function? Could this be done more elegantly by introducing a block flag like has_activation_function?
There was a problem hiding this comment.
I will look into this and possibly pull request later!
|
|
||
| // Create and set activation_function for vessel types that use one | ||
| if (vessel_type == "ChamberSphere") { | ||
| auto act_func = generate_activation_function( |
There was a problem hiding this comment.
Adapt error message of generate_activation_function to also include the new one
3 participants
Add option to select activation function for ChamberSphere
Current situation
Currently activation function is hard coded within ChamberSphere. As detailed in #236
Release Notes
Testing
Code of Conduct & Contributing Guidelines