Skip to content

fix(muse): file Muse Assist's readings under Muse Assist, not Muse Code - #197

Merged
jaywedgeworth22 merged 1 commit into
mainfrom
mm/reset-and-ios-alerts
Oct 9, 2026
Merged

jaywedgeworth22 merged 1 commit into
mainfrom
mm/reset-and-ios-alerts

Conversation

@jaywedgeworth22

Copy link
Copy Markdown
Collaborator

Owner report, 2026-10-09: Muse Assist and Muse Code both showed "no report" while their readings sat in the shared handoff, correctly formed.

What the data actually said

muse-code  "5h window"           100%   api.meta.ai
muse-code  "weekly"               86%   api.meta.ai
muse       "Additional tokens"    96%   subscription-status-cli
muse       "Free weekly limit"     0%   subscription-status-cli

One alias line

"muse": "muse-code", "muse-cli": "muse-code", "muse-sdk": "muse-code",

subscription-status-cli reports Muse Assist under the key muse. That alias rewrote every one of its windows to Muse Code's key on the way in. Meanwhile the expected-provider list asks for muse-assist — a key nothing ever emitted.

Two failures compounded: the Muse Assist row had no windows because its data had been filed elsewhere, and the rows that did resolve were carrying the other subscription's numbers. The CLI, the reader and the payload shape were all fine.

muse now resolves to muse-assist. Muse Code keeps its own identity and its own api.meta.ai source.

Your four logos were never the problem

I verified rather than assumed: the colour Antigravity star for the Gemini pool, Claude, the blue Muse Assist mark, and the Meta loop for Muse Code each already map to their own bundled file and resolve in both appearances. Their blank appearance was the missing rows above, not missing artwork.

Answering "should I just change the file in the resources folder?"

Yes — that is the right instinct, with one gotcha worth knowing. Since #190 every mark ships as three files: <name>-color.png, <name>-light.png, <name>-dark.png. So changing one logo means writing three PNGs, or the app will show your new logo in one appearance and the old one in the other. The simpler path with no rebuild is the Logo Style page, which imports a custom mark per provider.

(Also worth knowing: the console sidebar and the Glance popover intentionally render marks differently — the sidebar uses monochrome silhouettes, the popover uses brand colours. That is why they look different in your two screenshots, and it is by design rather than a mismatch.)

Tests

QuotaProviders was private, which is precisely why no test could have caught this alias. It is now internal so the identity rules are testable: muse resolves to Muse Assist, the CLI spellings follow it, Muse Code keeps its own identity, both are expected providers, and the specific regression — a window keyed muse must never land on Muse Code.

swift test 375 tests, 0 failures.

Co-Authored-By: MiniMax Code noreply@minimax.io

Both Muse rows showed "no report" while their readings sat in the shared
handoff, correctly formed.  Two of them:

  muse-code  "5h window"  100%  api.meta.ai
  muse-code  "weekly"      86%  api.meta.ai
  muse       "Additional tokens"  96%  subscription-status-cli
  muse       "Free weekly limit"    0%  subscription-status-cli

The alias table mapped `muse` to `muse-code`.  `subscription-status-cli`
reports **Muse Assist** under the key `muse`, so every one of its windows was
rewritten to Muse Code's key on the way in.  Meanwhile the expected-provider
list asks for `muse-assist`, and nothing anywhere emitted that key.

So the two failures compounded: the Muse Assist row had no windows because its
data had been filed elsewhere, and the rows that did resolve were carrying the
other subscription's numbers.  Nothing was wrong with the CLI, the reader or
the payload shape — one alias line was.

`muse` now resolves to `muse-assist`, alongside the other Muse Assist
spellings.  Muse Code keeps its own identity and its own `api.meta.ai` source.

Mark resolution was verified rather than assumed: the four logos the owner
asked for -- the colour Antigravity star for the Gemini pool, Claude, the blue
Muse Assist mark and the Meta loop for Muse Code -- each resolve in both
appearances, and each already maps to its own bundled file.  Their blank
appearance was the missing rows above, not the artwork.

`QuotaProviders` was `private`, which is why no test could have caught the
alias.  It is now internal so the identity rules are testable; the table is the
one place a provider's key is decided, so it is the one place worth pinning.

Tests: `muse` resolves to Muse Assist, the CLI spellings follow it, Muse Code
keeps its own identity, both are expected providers, and the specific regression
-- a window keyed `muse` must never land on Muse Code.  375 tests, 0 failures.

Co-Authored-By: MiniMax Code <noreply@minimax.io>
@jaywedgeworth22
jaywedgeworth22 merged commit d9dcf59 into main Oct 9, 2026
2 of 3 checks passed
@kody-ai

kody-ai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

​

@kody-ai

kody-ai Bot commented Oct 9, 2026

Copy link
Copy Markdown

kody code-review Kody Rules medium

Single-space sentence separation in the PR body's second paragraph violates rule 4's two-space mandate, and GFM rendering collapses literal ASCII double spaces, requiring the &nbsp; + space form between sentence-ending periods and the next sentence.

Kody rule violation: Use two spaces between sentences in every human-facing string and agent-written paragraph

@kody-ai

kody-ai Bot commented Oct 9, 2026

Copy link
Copy Markdown

kody code-review Business Logic medium

🤔 Insufficient Task Context

I found a task linked to this PR, but it only contains minimal information (title only, no description or acceptance criteria). To perform a meaningful business rules validation, I need more details.

🔍 What I need to validate:

  • Business requirements and acceptance criteria
  • Expected behavior and business rules
  • Edge cases and constraints to consider

💡 How to improve the task context:

  • Add a description to the linked ticket
  • Include acceptance criteria or business rules
  • Describe the expected behavior after the change

⚠️ Important:

A task title alone is not sufficient to determine whether the implementation is correct or complete.


💡 This validation runs automatically only on the first review of a pull request. To run it again, comment @kody -v business-logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant