Repository navigation
feat(pip): scroll the rows sideways once there is room for one row and a peek - #206
Conversation
…d a peek
Owner 2026-10-10: "once it gets to where it is in the screenshot or actually
80-100 pixels wider than that so that it could still have platform logos at
the left … we could make it scroll left to right like it now does up and
down."
Each row in the strip keeps its own logo at its left edge, so scrolling never
hides which platform you are looking at — which was the condition he attached
to the request in the first place ("assuming we finally can make the logos
actually show up"), and which #190 finally satisfied.
The threshold is DERIVED from the row's own width at the detail level in force
plus a 64pt peek, not hardcoded to his 80-100 figure: that figure is only
meaningful while the bar metrics behind it hold, and a hardcoded number would
silently rot the next time one moves. The detail level is computed from the
panel width first, so the width the strip demands is the width the row
actually wants — the two cannot disagree.
It lands in his band: the squeeze point is around 222pt and the switch is
roughly 90pt past it, which the test asserts so a future metric change cannot
quietly move the feature away from what was asked for.
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Formatting violation in Tests/CodeCapsTests/PipMetricsTests.swift: the paragraph ends one sentence at "hold." and starts the next with "The derived value", separated by a single ASCII space. Replace the lone space after "hold." with two ASCII spaces per source-comment rule [36], matching the existing convention ("switching to. Less", "changes. The", "end to end. Every"). Kody rule violation: Sentence gap by surface: two ASCII spaces in files, U+00A0 plus a space in rendered copy and GitHub text |
1 participant
Board
f324ec6, the second of the two PiP items.Each row in the strip keeps its own logo at its left edge, so scrolling never hides which platform you are looking at — the condition the owner attached to the request from the start, and which #190 finally satisfied.
The threshold is derived, not hardcoded. It is the row's own width at the detail level in force, plus a 64pt peek. The owner's 80-100pt figure is only meaningful while the bar metrics behind it hold, so a hardcoded number would silently rot the next time one moved. The detail level is computed from panel width first, so the width the strip demands is the width the row actually wants — the two cannot disagree.
It lands in his band: the squeeze point is ~222pt and the switch is ~90pt past it. A test asserts that band, so a future metric change cannot quietly move the feature away from what was asked for.
swift buildclean;swift test388 passed, 3 skipped, 0 failures.