Repository navigation
fix(ui): PiP horizontal fill and Glance console levels (CC-9, CC-26) - #239
Merged
Merged
Conversation
…CC-26) Use the themed PiP background for horizontally scrolling rows so the HUD does not show a grey groupBand inset after the header strip was removed. Extract GlanceWindowLevels for the popover versus elevated console ordering and add a unit test pinning CC-26. Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
Context
Most of CC-9 and CC-26 already shipped on
main(#193/#206/#208 for PiP; #163 for console elevation). This PR closes two small gaps:CC-9: Horizontally scrolling PiP rows still used
Theme.groupBand, which read as the grey/silver strip the owner wanted gone. Vertical rows already used the themedbackground.fill; horizontal rows now match.CC-26: Extract
GlanceWindowLevels(popUpMenuWindowvspopUpMenuWindow + 1) and add a unit test so the console-above-Glance contract does not live only inAppDelegate.Testing
GlanceWindowLevelsTests.testConsoleElevatedAboveGlancePopover(new)PipMetricsTests.testPanelIsResizableAndBoundedstill guards borderless PiP (no silver titlebar strip)Swift CI on macOS runners (no Swift toolchain in the Linux cloud agent VM).