Repository navigation
ci(CC-19): macOS compile gate for Swift CI and main protection - #241
Closed
jaywedgeworth22 wants to merge 1 commit into
Closed
jaywedgeworth22 wants to merge 1 commit into
jaywedgeworth22 wants to merge 1 commit into
Conversation
Add a dedicated Swift compile job on GitHub-hosted macOS runners, gate Mac release on it, and document the main-branch ruleset that requires Swift CI / compile (macOS). Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+40
to
+42
| { | ||
| "context": "Swift CI / compile (macOS)" | ||
| } |
There was a problem hiding this comment.
Bug: The required status check context Swift CI / compile (macOS) does not match any check run generated by the workflow, blocking PR merges indefinitely.
Severity: HIGH
Suggested Fix
Update the context in .github/rulesets/default-main-protection.json to match the exact check run name produced by swift-ci.yml, or adjust the workflow job name to align with the required status check.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: .github/rulesets/default-main-protection.json#L40-L42
Potential issue: The ruleset configures a required status check named `Swift CI /
compile (macOS)`. However, the workflow job does not emit a check matching this full
context name, meaning the required check will never report a status. Consequently, pull
requests targeting the protected branch will be indefinitely blocked from merging.
Did we get this right? 👍 / 👎 to inform future reviews.
Collaborator
Author
|
Closing as a duplicate of #236, which was opened first. — Deployer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: CC-19
Adds a dedicated Swift CI / compile (macOS) job on GitHub-hosted
macos-latestrunners and gatespackage,companion, and Mac release on it.Includes
.github/rulesets/default-main-protection.jsonandscripts/apply-main-compile-gate-ruleset.shto require the compile check onmain(run the script once after merge).Verification