Skip to content

CC-169: Turn off the Mac TestFlight ship - #272

Merged
jaywedgeworth22 merged 1 commit into
mainfrom
claude/cc-169-mac-testflight-off
Oct 19, 2026
Merged

jaywedgeworth22 merged 1 commit into
mainfrom
claude/cc-169-mac-testflight-off

Conversation

@jaywedgeworth22

@jaywedgeworth22 jaywedgeworth22 commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Refs CC-169

The user wants me to generate a precise pull request description based on the code changes provided. Let me analyze the changes:

  1. .github/workflows/ios-ship-contract.yml - Removed references to macos-ship.yml, mac-appstore-profiles.json, scripts/mac-*, scripts/macos-ship-workflow.test.mjs from path triggers. Updated the test command to only run the iOS ship workflow test.

  2. docs/IOS-TESTFLIGHT.md - Renamed section from "CodeCaps For Mac (TestFlight)" to "CodeCaps For Mac (Retired From TestFlight)" and rewrote the content to document what was removed and what stays.

  3. ios/CodeCapsCompanion/project.yml - Removed Apple Distribution signing overrides for the CodeCapsCompanionMac and CodeCapsWidgetsMac targets in Release configs.

  4. scripts/ios-ship-workflow.test.mjs - Removed the assertion that checks for the Mac ship cache key in macos-ship.yml.

  5. scripts/mac-ship-testflight.sh - Replaced the working wrapper with a stub that prints a retirement message and exits non-zero.

The overall purpose: Turning off the Mac TestFlight shipping pipeline. The Mac app no longer ships to TestFlight or the Mac App Store; it becomes a direct-download app released via GitHub Releases.

This pull request retires the Mac TestFlight shipping pipeline for CodeCaps, completing the CC-169 owner ruling (2026-10-19). The Mac app no longer uploads to TestFlight or ships through the Mac App Store; instead, it is distributed as a signed and notarized DMG via GitHub Releases through .github/workflows/mac-release.yml.

The changes:

  • Removes Mac TestFlight ship wiring from the CI contract. The iOS ship contract workflow no longer triggers on Mac ship paths (.github/workflows/macos-ship.yml, mac-appstore-profiles.json, scripts/mac-*, scripts/macos-ship-workflow.test.mjs) and its pinned test now runs only ios-ship-workflow.test.mjs. The Mac-specific cache-key assertion referencing macos-ship.yml is dropped from that test.
  • Removes Mac App Store signing overrides from the Xcode project. The CodeCapsCompanionMac and CodeCapsWidgetsMac targets in ios/CodeCapsCompanion/project.yml no longer carry the Release Apple Distribution / CodeCaps for Mac AppStore and CodeCaps Mac Widgets AppStore provisioning overrides. The targets still compile (Swift CI continues to build the widget extension without signing), but nothing archives or uploads them.
  • Replaces the Mac ship shell script with a retirement stub. scripts/mac-ship-testflight.sh previously delegated to the fleet's ship-testflight.sh for codecaps-mac; it now prints a message that Mac TestFlight shipping is retired and exits non-zero, so any stale caller fails loudly instead of uploading.
  • Updates documentation. docs/IOS-TESTFLIGHT.md renames the Mac section to "CodeCaps For Mac (Retired From TestFlight)" and documents what was removed (the workflow, its contract test, Mac App Store signing/export scripts, mac-appstore-profiles.json, the codecaps-mac apps.json entry, and the Apple Distribution signing overrides), what stays (the targets still build, mac-release.yml remains), and what is unchanged (the iOS ship pipeline).

Mac companion record comes off the App Store (owner ruling 2026-10-19).
Delete macos-ship.yml and its contract test, the Mac App Store signing
and export scripts, and mac-appstore-profiles.json.  Drop the codecaps-mac
entry from scripts/ios-fleet/apps.json and the Apple Distribution signing
overrides on the Mac targets in project.yml.  mac-ship-testflight.sh is now
a stub that exits non-zero.  mac-release.yml (the DMG on GitHub Releases) is
untouched.

Refs CC-169

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Oct 19, 2026

Copy link
Copy Markdown

CC-169

@jaywedgeworth22
jaywedgeworth22 enabled auto-merge (squash) October 19, 2026 16:51
@kody-ai

kody-ai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

⚠️ 2 Kody Rule(s) were not evaluated

These rules declare that they need repository context beyond this diff, and the review could not retrieve it, so they were not judged on this pull request:

  • Never move or delete existing app support.html URLs
  • Run verify-datadog.mjs when touching the Datadog integration
Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

​

@kody-ai

kody-ai Bot commented Oct 19, 2026

Copy link
Copy Markdown

kody code-review Business Logic medium

🤔 Insufficient Task Context

I found a task linked to this PR, but it only contains minimal information (title only, no description or acceptance criteria). To perform a meaningful business rules validation, I need more details.

🔍 What I need to validate:

  • Business requirements and acceptance criteria
  • Expected behavior and business rules
  • Edge cases and constraints to consider

💡 How to improve the task context:

  • Add a description to the linked ticket
  • Include acceptance criteria or business rules
  • Describe the expected behavior after the change

⚠️ Important:

A task title alone is not sufficient to determine whether the implementation is correct or complete.


💡 This validation runs automatically only on the first review of a pull request. To run it again, comment @kody -v business-logic.

@jaywedgeworth22
jaywedgeworth22 merged commit c4f094e into main Oct 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant