Repository navigation
CC-169: Turn off the Mac TestFlight ship - #272
Conversation
Mac companion record comes off the App Store (owner ruling 2026-10-19). Delete macos-ship.yml and its contract test, the Mac App Store signing and export scripts, and mac-appstore-profiles.json. Drop the codecaps-mac entry from scripts/ios-fleet/apps.json and the Apple Distribution signing overrides on the Mac targets in project.yml. mac-ship-testflight.sh is now a stub that exits non-zero. mac-release.yml (the DMG on GitHub Releases) is untouched. Refs CC-169 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀
|
| Options | Enabled |
|---|---|
| Bug | ✅ |
| Performance | ✅ |
| Security | ✅ |
| Business Logic | ✅ |
🤔 Insufficient Task ContextI found a task linked to this PR, but it only contains minimal information (title only, no description or acceptance criteria). To perform a meaningful business rules validation, I need more details. 🔍 What I need to validate:
💡 How to improve the task context:
|
Refs CC-169
The user wants me to generate a precise pull request description based on the code changes provided. Let me analyze the changes:
.github/workflows/ios-ship-contract.yml- Removed references to macos-ship.yml, mac-appstore-profiles.json, scripts/mac-*, scripts/macos-ship-workflow.test.mjs from path triggers. Updated the test command to only run the iOS ship workflow test.docs/IOS-TESTFLIGHT.md- Renamed section from "CodeCaps For Mac (TestFlight)" to "CodeCaps For Mac (Retired From TestFlight)" and rewrote the content to document what was removed and what stays.ios/CodeCapsCompanion/project.yml- Removed Apple Distribution signing overrides for theCodeCapsCompanionMacandCodeCapsWidgetsMactargets in Release configs.scripts/ios-ship-workflow.test.mjs- Removed the assertion that checks for the Mac ship cache key in macos-ship.yml.scripts/mac-ship-testflight.sh- Replaced the working wrapper with a stub that prints a retirement message and exits non-zero.The overall purpose: Turning off the Mac TestFlight shipping pipeline. The Mac app no longer ships to TestFlight or the Mac App Store; it becomes a direct-download app released via GitHub Releases.
This pull request retires the Mac TestFlight shipping pipeline for CodeCaps, completing the CC-169 owner ruling (2026-10-19). The Mac app no longer uploads to TestFlight or ships through the Mac App Store; instead, it is distributed as a signed and notarized DMG via GitHub Releases through
.github/workflows/mac-release.yml.The changes:
iOS ship contractworkflow no longer triggers on Mac ship paths (.github/workflows/macos-ship.yml,mac-appstore-profiles.json,scripts/mac-*,scripts/macos-ship-workflow.test.mjs) and its pinned test now runs onlyios-ship-workflow.test.mjs. The Mac-specific cache-key assertion referencingmacos-ship.ymlis dropped from that test.CodeCapsCompanionMacandCodeCapsWidgetsMactargets inios/CodeCapsCompanion/project.ymlno longer carry the ReleaseApple Distribution/CodeCaps for Mac AppStoreandCodeCaps Mac Widgets AppStoreprovisioning overrides. The targets still compile (Swift CI continues to build the widget extension without signing), but nothing archives or uploads them.scripts/mac-ship-testflight.shpreviously delegated to the fleet'sship-testflight.shforcodecaps-mac; it now prints a message that Mac TestFlight shipping is retired and exits non-zero, so any stale caller fails loudly instead of uploading.docs/IOS-TESTFLIGHT.mdrenames the Mac section to "CodeCaps For Mac (Retired From TestFlight)" and documents what was removed (the workflow, its contract test, Mac App Store signing/export scripts,mac-appstore-profiles.json, thecodecaps-macapps.json entry, and the Apple Distribution signing overrides), what stays (the targets still build,mac-release.ymlremains), and what is unchanged (the iOS ship pipeline).