Scope quota windows by producer instance by jaywedgeworth22 · Pull Request #1583 · Simple-With-Us/Usage-Monitor

jaywedgeworth22 · 2026-10-03T22:54:16Z

Summary

Scope quota windows by the optional producer instance ID so identical provider buckets or models reported by different machines remain separate.
Retain the newest reading independently for each producer/series combination.
Expose producerInstanceId and an optional human-readable machine label when supplied.
Preserve historical IDs and behavior for unattributed quota events while introducing collision-safe identifiers for producer-attributed windows.
Add regression coverage for multi-machine separation, newest-reading selection, identifier encoding, legacy ID collisions, and backward compatibility.
Record the work in the effort log. No ingestion or authentication behavior changes.

Open Review Findings

The effort-log entry still needs a link to the actual GitHub issue and must be mirrored in the external trading effort ledger.
A logical bucket can be returned twice when one collector supplies _producerInstanceId and another does not.
Producer-attributed window IDs can change between responses when an unrelated legacy bucket ID causes the collision fallback to be used.
The existing 400-row fetch budget is shared across machines and can omit windows for some producer instances.
skipModelTypes is aggregated across all machines, so a stale or exhausted Antigravity window on one machine can suppress that model fleet-wide.

Closes #1594

jaywedgeworth22 · 2026-10-04T06:22:57Z

@kody start-review

kody-ai

Found critical issues please review the requested changes

Link this work to its actual GitHub issue in addition to the existing board reservations.

…e-provenance

jaywedgeworth22 · 2026-10-05T04:13:30Z

@kody start-review

kody-ai · 2026-10-05T04:33:26Z

Use two literal spaces after the period in the PR description, or the required form when the renderer would collapse the gap.

Kody rule violation: Use two spaces between sentences in every human-facing string and agent-written paragraph

kody-ai · 2026-10-05T04:33:30Z

❌ Error processing validation

An error occurred while processing the system response. Please try again.

Details

Analyzer execution failed: Timeout after 120000ms in business-rules-analyzer-attempt-1

💡 This validation runs automatically only on the first review of a pull request. To run it again, comment @kody -v business-logic.

Load latest quota rows with a SQL window partition instead of take 2000. Only drop unattributed windows when a fresher attributed reading exists (provider-scoped). Enforce legacy/producer id collisions with suffix re-key. Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>

kody-ai · 2026-10-05T10:14:51Z

Public API coverage gap: loadLatestQuotaWindowEvents has Vitest coverage, but src/index.ts does not re-export it and its test imports the implementation module directly. Re-export it from src/index.ts and have the test import it from that public surface so consumers and tests exercise the same API.

Kody rule violation: Every exported schema or utility ships with tests and must typecheck

kody-ai · 2026-10-05T10:14:54Z

Renderer-unsafe sentence spacing in the PR description prevents the required two-sentence spacing from surviving rendering. Separate the two sentences with the renderer-safe   sequence.

Kody rule violation: Use two spaces between sentences in every human-facing string and agent-written paragraph

Keep this PR's machine-provenance effort-log row and take main's 2026-10-05 entries. Auto-merged muse into the quota-windows provider grouping test.

Bare catch {} swallowed $queryRaw errors and dropped to the 400-row findMany with no log. Capture the exception in Sentry (guarded so observability never blocks the fallback) and console.error the same failure.

Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>

Superseded: code findings addressed in b51655d/a626679 (Kody verified on threads); effort-log AGENT-SYNC linkage in e42a408; worktree path deferred with documented rationale. CI green on tip e42a408.

Loader returns quota events newest-first; reserving legacy ids in a separate pass keeps attributed collision re-keys correct regardless of input order. Regression test now covers both orderings. Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>

kody-ai · 2026-10-06T08:02:12Z

Code Review Could Not Complete ⚠️

The review failed before suggestions could be generated.

Reason: Rate limit reached on the provider (openai_compatible). Try again in a few minutes.

openai_compatible · MiniMax-M3.1-Flash-Preview · HTTP 429 · generalist

Provider said: Token Plan rate limit reached: Upgrade your Token Plan or switch to pay-as-you-go API usage. (2062)

After fixing the issue, comment @kody review on this PR to re-run the review.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Bug	✅
Performance	✅
Security	✅
Business Logic	✅

Access your configuration settings here.

kody-ai · 2026-10-06T08:09:21Z

+  },
+}));
+
+vi.mock("@sentry/nextjs", () => ({


The vi.mock call for @sentry/nextjs adds Sentry to the test module graph, violating Rule 94’s requirement that Datadog remain the sole observability backend. Refactor the loader and test to use and mock the project’s Datadog-backed observability abstraction instead.

Also found in:

src/lib/quota-events-loader.ts:2-2

src/lib/quota-events-loader.ts:83-83

Kody rule violation: Never expose secrets or private infrastructure values; reuse existing fleet env vars

Prompt for LLM

File src/lib/__tests__/quota-events-loader.test.ts: Line 18: The `vi.mock` call for `@sentry/nextjs` adds Sentry to the test module graph, violating Rule 94’s requirement that Datadog remain the sole observability backend. Refactor the loader and test to use and mock the project’s Datadog-backed observability abstraction instead. **Also found in:** - `src/lib/quota-events-loader.ts:2-2` - `src/lib/quota-events-loader.ts:83-83`

_{Talk to Kody by mentioning @kody}

_{Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.}

This comment has been minimized.

Sign in to view

kody-ai Bot reviewed Oct 4, 2026

View reviewed changes

Comment thread docs/EFFORT-LOG.md Outdated

kody-ai Bot reviewed Oct 4, 2026

View reviewed changes

Comment thread docs/EFFORT-LOG.md Outdated

kody-ai Bot reviewed Oct 4, 2026

View reviewed changes

Comment thread src/lib/quota-windows.ts

kody-ai Bot reviewed Oct 4, 2026

View reviewed changes

Comment thread src/lib/quota-windows.ts Outdated

kody-ai Bot reviewed Oct 4, 2026

View reviewed changes

Comment thread src/lib/quota-windows.ts

kody-ai Bot reviewed Oct 4, 2026

View reviewed changes

Comment thread src/lib/quota-windows.ts

kody-ai Bot previously requested changes Oct 4, 2026

View reviewed changes

jaywedgeworth22 pushed a commit that referenced this pull request Oct 4, 2026

fix: address Kodus review findings (PR #1583)

fe3f31a

This comment has been minimized.

Sign in to view

jaywedgeworth22 and others added 4 commits October 4, 2026 21:19

Expose machine provenance in quota windows

5b6e680

Record quota provenance pull request

2f37c9f

Prevent quota window provenance ID collisions

7139c53

fix: address Kodus review findings (PR #1583)

777091b

jaywedgeworth22 force-pushed the codex/codecaps-machine-provenance branch from 9cb9b19 to 777091b Compare October 5, 2026 02:22

This comment has been minimized.

Sign in to view

jaywedgeworth22 mentioned this pull request Oct 5, 2026

Producer quota windows for subscription usage #1594

Closed

jaywedgeworth22 added 2 commits October 4, 2026 23:07

Merge remote-tracking branch 'origin/main' into codex/codecaps-machin…

29cd10b

…e-provenance

docs(effort-log): link issue #1594 on the PR #1583 row

9f897b9

This comment has been minimized.

Sign in to view

kody-ai Bot reviewed Oct 5, 2026

View reviewed changes

Comment thread docs/EFFORT-LOG.md Outdated

kody-ai Bot reviewed Oct 5, 2026

View reviewed changes

Comment thread docs/EFFORT-LOG.md Outdated

kody-ai Bot reviewed Oct 5, 2026

View reviewed changes

Comment thread src/app/api/quota-windows/route.ts Outdated

kody-ai Bot reviewed Oct 5, 2026

View reviewed changes

Comment thread src/lib/quota-windows.ts Outdated

kody-ai Bot reviewed Oct 5, 2026

View reviewed changes

Comment thread src/lib/quota-windows.ts Outdated

This comment has been minimized.

Sign in to view

jaywedgeworth22 added 2 commits October 5, 2026 13:36

Merge origin/main into codex/codecaps-machine-provenance

57fcb06

Keep this PR's machine-provenance effort-log row and take main's 2026-10-05 entries. Auto-merged muse into the quota-windows provider grouping test.

fix(quota): report window-query failures before findMany fallback

a626679

Bare catch {} swallowed $queryRaw errors and dropped to the 400-row findMany with no log. Capture the exception in Sentry (guarded so observability never blocks the fallback) and console.error the same failure.

jaywedgeworth22 enabled auto-merge (squash) October 6, 2026 07:54

cursoragent and others added 2 commits October 6, 2026 07:55

Merge origin/main into codex/codecaps-machine-provenance

769ac97

Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>

docs(effort-log): note AGENT-SYNC coordination on PR #1583 row

e42a408

Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>

This comment has been minimized.

Sign in to view

kody-ai Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread docs/EFFORT-LOG.md

kody-ai Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread docs/EFFORT-LOG.md

kody-ai Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread docs/EFFORT-LOG.md

jaywedgeworth22 merged commit 29af702 into main Oct 6, 2026
10 of 11 checks passed

jaywedgeworth22 deleted the codex/codecaps-machine-provenance branch October 6, 2026 08:05

kody-ai Bot reviewed Oct 6, 2026

View reviewed changes

Conversation

jaywedgeworth22 commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Open Review Findings

Uh oh!

jaywedgeworth22 commented Oct 4, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kody-ai Bot left a comment

Choose a reason for hiding this comment

Found critical issues please review the requested changes

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jaywedgeworth22 commented Oct 5, 2026

Uh oh!

This comment has been minimized.

kody-ai Bot commented Oct 5, 2026

Uh oh!

kody-ai Bot commented Oct 5, 2026

Details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

kody-ai Bot commented Oct 5, 2026

Uh oh!

kody-ai Bot commented Oct 5, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

kody-ai Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Could Not Complete ⚠️

Uh oh!

Uh oh!

kody-ai Bot Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jaywedgeworth22 commented Oct 3, 2026 •

edited

Loading

kody-ai Bot commented Oct 6, 2026 •

edited

Loading