Repository navigation
fix(deps): patch sharp librsvg advisory - #1613
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Patch the existing sharp override from 0.35.4 to 0.35.5 and refresh only its native-package lock entries. No new override, framework upgrade, audit waiver or application behavior change is introduced.
Why
The newly published GHSA-wq5f-xc86-pv6w flags sharp <0.35.5 because bundled librsvg can be unsafe under specific glibc Linux conditions. This blocks the unchanged dependency baseline in Sentry PR #1611. Sharp 0.35.5 bundles fixed librsvg 2.63.2.
Next 16.3.8 accepts ^0.35.4. The existing override already unifies Miniflare's exact sharp dependencies; this patch retains that established arrangement.
Verification
Clean npm ci, high-severity audit gate, typecheck, and synthetic SVG resize passed locally. Runtime reports sharp 0.35.5 / librsvg 2.63.2. Production build and all exact-head hosted checks passed. Squash merge fefecc3 is deployed: public health reports live/production and readiness reports ok:true on that exact SHA. Independent lockfile review confirms only sharp-family packages changed and Node 24 compatibility. No malicious image or real user content is used.
Coordination
Separate dependency lane reserved as 6c3e5594c91b47e3bd3097fd5ccb6009; app Slack overlap check completed. Existing dependency PRs #1606/#1598 touch the lockfile for other packages and must be reconciled normally. Sentry SDK #1611 and held reporter #1612 are unchanged. Task notes remain here under the authorized code-only publication approach; no giant documentation uploads. Merged after exact-head gates and independent review passed.