Repository navigation
test(e2e): guard missing visual baselines (UM-1586 / UM-1584) - #1664
Merged
Merged
Conversation
UM-1586 / UM-1584: #1615 added fleet-budget screenshots without committed baselines; #1654 regenerated money (1280x1152) and fleet-budget PNGs on ubuntu-latest. Main smoke is green; this guard catches the same gap before Playwright runs. Co-authored-by: Jay Wedgeworth <jaywedgeworth22@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context (UM-1586 / UM-1584)
E2E smoke on
mainfailed after #1615 (f5a6757) because that merge addedfleet-budget-{desktop,mobile}toHaveScreenshotassertions and mountedFleetBudgetCardon/moneywithout committing baseline PNGs. The money full-page shot also grew from 1280×720 to 1280×1152 (expected: fleet budget card on Money), while the committedmoney-chromium-linux.pngstayed at 720px height.That is not a layout regression — it is the intentional Money-page fleet monitor from #1615.
#1654 (
905dfd8) already regeneratedfleet-budget-*andmoneybaselines on the ubuntu-latest Playwright runner;mainE2E smoke is green again (verified locally:npx playwright test10/10).This PR
Adds a fast preflight in the E2E workflow (
node scripts/test-e2e-visual-snapshot-files.mjs) so a PR cannot merge newtoHaveScreenshotnames without matching*-chromium-linux.pngfiles undertests/e2e/visual.spec.ts-snapshots/.No baseline image changes in this PR (re-running
--update-snapshotson linux produced zero diff againstmain).