Repository navigation
fix(ci): mask the base64 ASC key before it reaches GITHUB_ENV - #1857
Merged
Merged
Conversation
Member
Author
|
@kody start-review |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations.
|
| Options | Enabled |
|---|---|
| Bug | ✅ |
| Performance | ✅ |
| Security | ✅ |
| Business Logic | ✅ |
jaywedgeworth22
enabled auto-merge (squash)
November 1, 2026 21:36
jaywedgeworth22
enabled auto-merge (squash)
November 1, 2026 21:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes log exposure of the App Store Connect signing key by masking secrets before they are persisted to
GITHUB_ENV.ios-ship.yml, masks every line of the raw PEM individually — a single multilineadd-maskonly covers the first line — and computes the base64APPLE_API_KEY_P8_BASE64value intokey_b64and masks it before writing it toGITHUB_ENV, since GitHub prints later steps' env blocks in the public log. Clearskey_b64from memory after use.ios-appstore-gm.yml, changes Infisical secret masking from a singleadd-maskper value to per-line masking.test-ios-stage-asc-key.shto enforce mask-before-write ordering for the base64 key, verify each PEM line and the base64 form are carried via::add-mask::, and fail if key material appears outside a mask carrier.