Updates - #558
Conversation
|
That test error on .net11 looks really strange. The actual and expected size differ quite a lot. On .net10 everything works. |
It’s possible to download the failed artefacts from that test (see ci output for link). We can use that to figure out what is happening. |
Reproduced on my machine .net11 |
|
Interesting! So this is one of three things. A bug in our code |
would you mind checking it on win? |
|
I'll have to wait until tomorrow my time now. it's late here. Hopefully I can figure it out quickly. |
When it is not reproducible on win. Then let me know. I can give you access to my Mac. |
CffBoundsFinder.GetBounds() cast the float.MaxValue/MinValue straight to short when a charstring never emitted a path operation (e.g. the space glyph). That overflow is unspecified by the C# spec; .NET 10 happened to produce small values, but .NET 11 preview saturates to short.MinValue/MaxValue instead, producing bogus +/-32767 unit bounds that blew up text layout for any run containing a space in a CFF font. Return Bounds.Empty when no point was ever recorded.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
======================================
- Coverage 81% 80% -1%
======================================
Files 406 406
Lines 35672 35674 +2
Branches 5561 5518 -43
======================================
- Hits 29126 28840 -286
- Misses 5375 5397 +22
- Partials 1171 1437 +266
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@JimBobSquarePants This is the documentation to the change in the runtime which caused this. |
I actually had a hunch it might be that change. it bit me during some testing a while back. |
2 participants
Updated to .net10/.net11
Migrated to slnx
Updated SharedInfrastructure for XUnit.V3 v4 💩💩💩