finalized dist archived dw - #16
Open
conordoremus wants to merge 5 commits into
Open
conordoremus wants to merge 5 commits into
conordoremus wants to merge 5 commits into
Conversation
alanalutz
force-pushed
the
finalized_dist_archived_dw
branch
from
September 9, 2026 15:45
25acc6f to
c523c77
Compare
alanalutz
marked this pull request as ready for review
September 9, 2026 15:46
alanalutz
requested changes
Sep 9, 2026
alanalutz
left a comment
alanalutz
left a comment
Collaborator
There was a problem hiding this comment.
I didn't really review the archived dynamic world code, but we can always come back to it later if it needs to be fixed up and used. I did review and leave a couple of small comments on DIST_ALERT.ipynb.
| "from disturbance.dw_results import results_to_summary_df, results_to_transitions_df, get_transition_mask\n", | ||
| "\n", | ||
| "from disturbance.dw_visualization import visualize_dw_on_map, plot_lc_change\n", | ||
| "\n", |
Collaborator
There was a problem hiding this comment.
These imports don't match the capitalization in the filenames that they import from, so the imports fail.
e.g. dist_status --> DIST_STATUS
Collaborator
There was a problem hiding this comment.
With the map visualization it is difficult to tell which layer is derived from VEGDISTSTATUS and which layer is derived from VEGANOMMAX + VEGDISTCONF. It would be nice if the code would instead produce a map with 2 clearly labeled layers to directly compare the two outputs.
conordoremus
force-pushed
the
finalized_dist_archived_dw
branch
from
September 18, 2026 17:25
c523c77 to
a88bae0
Compare
* added dir and code for creating test/control grids as an input for future propensity score steps * added geopandas to toml * set up psm testing notebook * added archive directory locally, including it in the gitignore * added geopandas * added numpy * updated to output parquet, gave option to save intermediate files * added data dir for repo-based files * added variables related to PSM grid creation * add pyarrow to toml --------- Co-authored-by: alanalutz <81712531+alanalutz@users.noreply.github.com>
…rld which now includes a documentation notebook and all related modules and .py files.
…le dw_variables.py
…are distinguishable from layers showing disturbance status and added a colorbar to show DIST AC disturbance percentage.
conordoremus
force-pushed
the
finalized_dist_archived_dw
branch
from
September 18, 2026 20:31
a88bae0 to
da22e22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Archived all work relating to Dynamic World in the
notebooks/archive/dynamic_worldfolder and updated the branch to reflect the status ofmain.All analysis and code written for Dynamic World (prefix dw_) was moved into the archive under
notebooks/archive/dynamic_world. This code is flawed and the notebook contains errors, like broken data pipelines and unfinished analysis, that were not resolved at this point but are explicitly mentioned in the dist_dw_psm.ipynb. Leaving them in the archive means they will not be lost and can be returned to if Dynamic World or a similar data source is used in the future.Created, updated, or replaced Files and/or tables
DIST_ALERT.ipynb: removed all dynamic world and propensity score matching - now only includes dist related worknotebooks/archive/dynamic_world: an archive folder containing all Dynamic World related work and the PSM attemptsdist_dw_psm.ipynb: a notebook that walks the user through the Dynamic World functions and attempts at integration into PSMdw_analysis: moved to archivedw_builders: moved to archivedw_results: moved to archivedw_variables: created to move variables to the archivedw_visualization: moved to archiveNotes for reviewers
The main notebook
DIST_ALERT.ipynbas it is in this PR should be production ready, so any feedback is most important and crucial at this point.Stack created with GitHub Stacks CLI • Give Feedback 💬