SourceGenerators: Emit BuildAsync for async assemble - #329
Merged
Conversation
Keep the required-step type-state gate for I/O assemble without a sync-over-async Build. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Contributor
There was a problem hiding this comment.
Stale comment
Autopilot: merge-ready.
- Mergeable (no conflicts); head is 1 commit ahead of
main, 0 behind.- Required CI green:
build-test,build-test-net48,pack.- No unresolved review threads or actionable comments.
Leaving merge to @Skymly.
Sent by Cursor Automation: DesignPatterns — Autopilot PR
Contributor
There was a problem hiding this comment.
Autopilot: merge-ready.
- Mergeable (no conflicts); head is 1 commit ahead of
main, 0 behind. - Required CI green:
build-test,build-test-net48,pack. - No unresolved review threads or actionable comments.
Leaving merge to @Skymly.
Sent by Cursor Automation: DesignPatterns — Autopilot PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
[BuilderAssemble]returnsTask<T>orValueTask<T>, emit type-state–gatedBuildAsync(CancellationToken cancellationToken = default)instead ofBuild().CancellationToken(excluded from step binding) and return the assemble task/value-task directly.Task/ValueTask, duplicate assemble, and multipleCancellationTokenparameters. Sync assemble still emits onlyBuild().Related Issue
Closes #326
Relates to #324
Follow-up docs: #327
Solution module
DesignPatterns.SourceGenerators/)Type of change
Test plan
./build.ps1 --target Ci --configuration Release(orCiPackif packaging changed)./build.ps1 --target Ci— tracked as DesignPatterns.Samples#29, not blocking this PRBreaking changes
Checklist
Documentation checklist
[Unreleased]updated for generatedBuildAsync