Concentrate gRPC unary and server-stream pumps behind thin adapters - #265
Merged
Conversation
Unary and server-stream loops were cloned. Leave client/duplex subscribe in adapters because Observable vs IObservable and write/read ordering differ. Closes #256
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Internal
GrpcProtocolowns unary, server-stream read loop, and WriteRequestAsync. Client/duplex stay in adapters (Observable vs IObservable and write/read ordering).Related Issue
Closes #256
Solution module
Type of change
Test plan
Breaking changes
Checklist