feat(restapi): add helm PodDisruptionBudget#201
Open
giuliocalzo wants to merge 1 commit into
Open
Conversation
Add an optional PodDisruptionBudget for the slurmrestd (RestApi) pods in the slurm chart. The PDB selector matches the labels the operator applies to the slurmrestd pods (app.kubernetes.io/name=slurmrestd and app.kubernetes.io/instance=<release fullname>). It is gated behind restapi.pdb.enabled and only rendered when restapi.replicas > 1, since a PDB on a single-replica Deployment would block all voluntary evictions. Supports minAvailable (default) and maxUnavailable (takes precedence when set).
giuliocalzo
requested review from
SkylerMalinowski,
alanmutsch,
catblade,
vivian-hafener and
wickberg
as code owners
giuliocalzo
changed the title
giuliocalzo
changed the title
vivian-hafener
removed request for
SkylerMalinowski,
alanmutsch,
catblade and
wickberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PodDisruptionBudgetfor the slurmrestd (RestApi) pods in theslurmHelm chart.app.kubernetes.io/name=slurmrestdandapp.kubernetes.io/instance=<release fullname>), via a newslurm.restapi.selectorLabelshelper.restapi.pdb.enabledand only rendered whenrestapi.replicas > 1(a PDB on a single-replica Deployment would block all voluntary evictions).minAvailable(default1) andmaxUnavailable(takes precedence when set).This is implemented purely at the Helm level; no CRD/operator (Go) changes.
Test plan
helm templaterenders the PDB with correct name, namespace, labels and selector.helm unittestsuitetests/restapi_pdb_test.yaml(6 cases): disabled, single-replica skip, metadata/selector/spec, custom minAvailable, maxUnavailable precedence, namespaceOverride.helm lint/make helm-validatepass.