Skip to content

feat: promote and refine performance settings #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Slush97 merged 4 commits into from
Aug 19, 2026
Merged

feat: promote and refine performance settings #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
877e2f1
fix(locker): center general empty states
Slush97 Aug 19, 2026
4fc6bf9
feat(settings): promote performance configs
Slush97 Aug 19, 2026
16bf56c
chore(i18n): refresh locale manifest
Slush97 Aug 19, 2026
c65dba2
fix(performance): address review findings
Slush97 Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions electron/main/services/performanceConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,7 @@ export function listPerformancePresets(): PerformancePresetSummary[] {
ref: release.ref,
refKind: release.refKind,
commit: release.commit,
historyCommit: release.historyCommit,
date: release.date,
settingCount: release.convars.length + release.sectionOps.length,
optIn: release.optIn.map((control) => ({
Expand Down
18 changes: 18 additions & 0 deletions electron/main/services/performanceConfigData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ export interface PresetRelease {
refKind: 'tag' | 'prose';
/** Immutable pin. This, not `ref`, is what was fetched. */
commit: string;
/** Last commit at or before the pin that touched this preset's file.
* Prose history is path-scoped, so this is its row identity. */
historyCommit: string;
/** Upstream release date, yyyy-mm-dd. Tag names do not reliably sort
* into release order, so this is what the picker shows to disambiguate. */
date: string;
Expand Down Expand Up @@ -240,6 +243,7 @@ const SqookyDefault: PerformancePresetFamily = {
ref: '2.9',
refKind: 'prose',
commit: '96ff42d1db29ca9fe44afb3df749fa763bb87b87',
historyCommit: 'ca74b464b16d4c2e2eee38d8a23b67efd98e4975',
date: '2026-08-17',
sha256: 'b31825fea70a48412b304b5f3dd06c24d5c29d9feb98d559d337eaef928457f3',
sectionOps: [
Expand Down Expand Up @@ -549,6 +553,7 @@ const SqookyDefault: PerformancePresetFamily = {
ref: '2.8.2',
refKind: 'prose',
commit: 'a7ba9d63dc6bb660208374ba2f18955e77042442',
historyCommit: 'a7ba9d63dc6bb660208374ba2f18955e77042442',
date: '2026-08-02',
sha256: '6c3753fabda7c724a01c9a9747e4a14c8618fe3815ecddae929623252e60db5c',
sectionOps: [
Expand Down Expand Up @@ -866,6 +871,7 @@ const SqookyDefault: PerformancePresetFamily = {
ref: '2.7',
refKind: 'prose',
commit: '271befb5cf9f8c9431da81e39ea4147895604d3e',
historyCommit: '271befb5cf9f8c9431da81e39ea4147895604d3e',
date: '2026-07-25',
sha256: 'c34801cc66cdd93e3dc0bfea275c98fa9c2a3cc29ee17a1f0397314a2310aeca',
sectionOps: [
Expand Down Expand Up @@ -1182,6 +1188,7 @@ const SqookyTesting: PerformancePresetFamily = {
ref: '2.9',
refKind: 'prose',
commit: '96ff42d1db29ca9fe44afb3df749fa763bb87b87',
historyCommit: '96ff42d1db29ca9fe44afb3df749fa763bb87b87',
date: '2026-08-17',
sha256: '362c7c577c37f821cf9f484f4505c7a21afecc014e3064e77798ede620189d55',
sectionOps: [
Expand Down Expand Up @@ -1528,6 +1535,7 @@ const SqookyTesting: PerformancePresetFamily = {
ref: '2.8.2',
refKind: 'prose',
commit: 'a7ba9d63dc6bb660208374ba2f18955e77042442',
historyCommit: '43c6aca8583524e87e54977ed963aebc0e89b678',
date: '2026-08-02',
sha256: '7cb2c5d0f7100d90e6f4ddd4fa8b067533d2bcd3a520ebe936fec75263c4084b',
sectionOps: [
Expand Down Expand Up @@ -1895,6 +1903,7 @@ const SqookyTesting: PerformancePresetFamily = {
ref: '2.7',
refKind: 'prose',
commit: '271befb5cf9f8c9431da81e39ea4147895604d3e',
historyCommit: '48383a17d0cb00927dd8713fe0a6b04c4b218f5a',
date: '2026-07-25',
sha256: 'b8e2e34ae293d9a6d3a5bd115d6f92626d19662684033beb906401f6a7b6f0bf',
sectionOps: [
Expand Down Expand Up @@ -2283,6 +2292,7 @@ const BootMaxFps: PerformancePresetFamily = {
ref: '2.9',
refKind: 'prose',
commit: '96ff42d1db29ca9fe44afb3df749fa763bb87b87',
historyCommit: '91ca1cb14f4e8fcbb77d310d09fd6683edab68dc',
date: '2026-08-17',
sha256: '6dbc82150afe2ec409646025b2437b093aab18d852a7329b80aded2ffb7cf0e5',
// Byte-identical upstream in 2.8.2, 2.7, collapsed into this entry.
Expand Down Expand Up @@ -2737,6 +2747,7 @@ const KaizuMinSpec: PerformancePresetFamily = {
ref: '2.9',
refKind: 'prose',
commit: '96ff42d1db29ca9fe44afb3df749fa763bb87b87',
historyCommit: '528ded17e7b89480fe1b896615099e4fa3511676',
date: '2026-08-17',
sha256: '16e9e739b90941543f2fabeea8161fd15327df5f16d812377fbd2bf4e75a98a4',
sectionOps: [
Expand Down Expand Up @@ -2999,6 +3010,7 @@ const KaizuMinSpec: PerformancePresetFamily = {
ref: '2.8.2',
refKind: 'prose',
commit: 'a7ba9d63dc6bb660208374ba2f18955e77042442',
historyCommit: '068f6d01b7920675e2360a7fca4f120dd07c05bd',
date: '2026-08-02',
sha256: 'e4be5933e6f24de0c368c77957dd7579ef8e2e8169fe4e9740977c09db08fa68',
sectionOps: [
Expand Down Expand Up @@ -3430,6 +3442,7 @@ const KaizuMinSpec: PerformancePresetFamily = {
ref: '2.7',
refKind: 'prose',
commit: '271befb5cf9f8c9431da81e39ea4147895604d3e',
historyCommit: '983d51a5c7567be9e6efbdd445304e51146793c5',
date: '2026-07-25',
sha256: 'f27e7d6fd479472f4aa127d4dd5eadb8ec6805e71e3f561e6f02ff879354c1c9',
sectionOps: [
Expand Down Expand Up @@ -3857,6 +3870,7 @@ const OptilockFps: PerformancePresetFamily = {
ref: 'v4.6',
refKind: 'tag',
commit: '6caab13036711d09ae439b4de4406bdb9972e148',
historyCommit: '6caab13036711d09ae439b4de4406bdb9972e148',
date: '2026-08-15',
sha256: 'ce1b084d986de7807f1a456c6845b232f08396e545ff0b133fdfc4a135df16c8',
sectionOps: [
Expand Down Expand Up @@ -4280,6 +4294,7 @@ const OptilockFps: PerformancePresetFamily = {
ref: 'v4.2',
refKind: 'tag',
commit: 'fdfce93a95db176c539d3dbcb601238e181008b9',
historyCommit: 'fdfce93a95db176c539d3dbcb601238e181008b9',
date: '2026-07-15',
sha256: '34873789e25b552829cff843b111b7c5f7f3127651a31d6e3f7fd1d67a2e1291',
sectionOps: [
Expand Down Expand Up @@ -4799,6 +4814,7 @@ const OptilockFps: PerformancePresetFamily = {
ref: 'v4.0d',
refKind: 'tag',
commit: '465590a35d8d47d84b78031837fa209f5a2b5ce7',
historyCommit: '465590a35d8d47d84b78031837fa209f5a2b5ce7',
date: '2026-07-12',
sha256: 'a0017f99282415dc027a687fdf01b06de707d6d28c5fbd161339493db4f1f618',
sectionOps: [
Expand Down Expand Up @@ -5343,6 +5359,7 @@ const OptilockMax: PerformancePresetFamily = {
ref: 'v4.6',
refKind: 'tag',
commit: '6caab13036711d09ae439b4de4406bdb9972e148',
historyCommit: '6caab13036711d09ae439b4de4406bdb9972e148',
date: '2026-08-15',
sha256: '5c3d4956117ffdf7c583042b23f34185ca95f91f346eb77ab86764106722f703',
sectionOps: [
Expand Down Expand Up @@ -5876,6 +5893,7 @@ const OptilockMax: PerformancePresetFamily = {
ref: 'v4.2',
refKind: 'tag',
commit: 'fdfce93a95db176c539d3dbcb601238e181008b9',
historyCommit: 'fdfce93a95db176c539d3dbcb601238e181008b9',
date: '2026-07-15',
sha256: '69032638fda021655d21e5ff8aaf8c53f903c32d55853a576575efd4dfe13326',
// Byte-identical upstream in v4.0d, collapsed into this entry.
Expand Down
30 changes: 30 additions & 0 deletions scripts/gen-performance-presets.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,26 @@ async function commitDate(repo, commit) {
return (await res.json()).commit.author.date.slice(0, 10);
}

// A prose "release" pin is a repository snapshot, but the history modal lists
// only commits that touched one preset's file. Resolve the last such commit at
// the snapshot so the renderer can identify bundled rows without fetching
// every historical file or guessing from commit-message prose.
async function lastPathCommit(repo, commit, path) {
const query = new URLSearchParams({ sha: commit, path, per_page: '1' });
const res = await fetch(`https://api.github.com/repos/${repo}/commits?${query}`, GH);
if (!res.ok) {
fail(
`Could not resolve path history for ${repo}@${commit.slice(0, 8)} ${path} ` +
`(${res.status})`
);
}
const commits = await res.json();
if (!Array.isArray(commits) || !commits[0]?.sha) {
fail(`No path history for ${repo}@${commit.slice(0, 8)} ${path}`);
}
return commits[0].sha;
}

// A source pinned with refKind 'tag' claims, in the UI, that the preset comes
// from a published release. Tags are mutable, so that claim can quietly become
// false. The commit is still what we fetch and the sha256 still gates content:
Expand Down Expand Up @@ -254,6 +274,9 @@ function emit(manifest, presets) {
L.push(` refKind: 'tag' | 'prose';`);
L.push(` /** Immutable pin. This, not \`ref\`, is what was fetched. */`);
L.push(` commit: string;`);
L.push(` /** Last commit at or before the pin that touched this preset's file.`);
L.push(` * Prose history is path-scoped, so this is its row identity. */`);
L.push(` historyCommit: string;`);
L.push(` /** Upstream release date, yyyy-mm-dd. Tag names do not reliably sort`);
L.push(` * into release order, so this is what the picker shows to disambiguate. */`);
L.push(` date: string;`);
Expand Down Expand Up @@ -350,6 +373,7 @@ function emit(manifest, presets) {
L.push(` ref: ${q(r.ref)},`);
L.push(` refKind: ${q(r.refKind)},`);
L.push(` commit: ${q(r.commit)},`);
L.push(` historyCommit: ${q(r.historyCommit)},`);
L.push(` date: ${q(r.date)},`);
L.push(` sha256: ${q(r.sha256)},`);
if (r.supersedes.length) {
Expand Down Expand Up @@ -512,6 +536,11 @@ async function main() {
continue;
}

const historyCommit =
source.refKind === 'prose'
? await lastPathCommit(source.repo, release.commit, path)
: release.commit;

const label = source.releases.length > 1 ? `${entry.id}@${release.ref}` : entry.id;
const { sectionOps, convars, optIn } = diffAgainstBaseline(
baseline,
Expand All @@ -527,6 +556,7 @@ async function main() {
ref: release.ref,
refKind: source.refKind,
commit: release.commit,
historyCommit,
date: release.date,
sha256: expected,
supersedes: [],
Expand Down
4 changes: 2 additions & 2 deletions src/components/performance/GameplayOptIns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ export default function GameplayOptIns({
})).filter((g) => g.controls.length > 0);

return (
<div className="rounded-sm border border-white/5 bg-bg-tertiary/40">
<div className="overflow-hidden rounded-sm border border-white/5 bg-bg-tertiary/30">
<button
type="button"
onClick={() => setExpanded((v) => !v)}
aria-expanded={expanded}
className="w-full flex items-center justify-between gap-3 px-4 py-3 text-left cursor-pointer hover:bg-white/[0.03] transition-colors focus:outline-none focus-visible:ring-2 focus-visible:ring-accent rounded-sm"
className="flex w-full cursor-pointer items-center justify-between gap-3 px-4 py-3.5 text-left transition-colors hover:bg-white/[0.03] focus:outline-none focus-visible:ring-2 focus-visible:ring-accent"
>
<span className="flex items-center gap-2 min-w-0">
<Eye className="w-4 h-4 text-accent shrink-0" aria-hidden="true" />
Expand Down
Loading