feat: add OLED mode - #372
Merged
Merged
Conversation
- Seed the OLED theme before first paint via preload argv (additionalArguments), killing the grey startup flash the mode exists to remove; Layout skips applying until settings arrive - Move color-scheme: dark to base :root so UA-drawn controls stop flipping light/dark with the OLED toggle - Derive scrim-bottom and gradient preview swatches from the bg-primary token so they track OLED black - Match the new Appearance divider to its bg-white/5 siblings - Single source for the base color: BACKGROUND_BASE moves to the DOM-free oledMode.ts (main-safe), dropping the third #0f0f0f copy - Read settings once in createWindow; extract syncWindowBackgroundWithSettings mirroring the forge-bridge pattern Claude-Session: https://claude.ai/code/session_01R3Gh42PwckvbxJhY4WGmer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #371
Validation
pnpm vitest run src/lib/oledMode.test.ts electron/main/services/settingsMigration.test.tspnpm typecheckpnpm lintpnpm i18n:checkpnpm buildpnpm test(101 files and 1,275 tests passed; 12 unrelated existing Windows platform/CRLF assertions failed in steamRoots, bottleLaunch, launchOptions, and performanceConfig)