Repository navigation
chore(renovate): hold the Headlamp plugin's TypeScript below 7 - #2069
Merged
Merged
Conversation
typescript-eslint, via @headlamp-k8s/eslint-config, refuses TS 7, so the plugin image fails at npm run lint. #2032 proposed it anyway. Lift once typescript-eslint/typescript-eslint#10940 lands.
1 task
Contributor
🔍 Rendered manifest diff — this PR vs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate proposed TypeScript 5.9.3 → 7 for the Headlamp plugin in #2032, and its image build fails at
npm run lint:Upstream support is tracked in typescript-eslint#10940. Nothing in this repo can fix it. This adds a
packageRuleshold, shaped like the existing google-provider hold:typescriptis capped at<7, scoped tocontainer-images/headlamp-plugin-app/**. Renovate may still propose 6.x, and CI will judge that one on its own.Installation, not a decision: nothing competed with it, so no ADR.
Evidence
renovate-config-validator .github/renovate.json:Config validated successfully against 1 file(s)packageRules. The new rule matchestypescriptincontainer-images/headlamp-plugin-app/**withallowedVersions: "<7".Supersedes #2032.