Fix issues 376-379 - #436
Merged
ritaifeoluwa merged 1 commit intoSep 26, 2026
Merged
Conversation
|
@rikkk-j Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You're right. The credential identity is
rikkk-j; I tried remotes owned by other accounts. I’ll check whether your fork isrikkk-j/smartdrop-backend, then push the committed branch there and open the PR from that fork.Ran terminal command: git status --short --branch; git log -1 --oneline; git remote -v
Ran terminal command: git ls-remote https://github.com/rikkk-j/smartdrop-backend.git HEAD refs/heads/main
Your fork exists and its
mainmatches current upstream. I’ve confirmed the local branch is clean and committed atd211b64; I’m pushing it torikkk-j/smartdrop-backendnow.Ran terminal command: git push -u https://github.com/rikkk-j/smartdrop-backend.git fix/issues-376-377-378-379
Creating pull request
Completed with input: {
"repo": {
"owner": "SmartDropLabs",
"name": "smartdrop-backend"
},
"title": "Fix circuit breaker, DB health, logging, and validation issues",
"body": "## Summary\n- Count resolved
nullandundefinedcircuit-breaker calls as successes; thrown errors remain failures.\n- Ping configured PostgreSQL databases from/healthwith bounded connection and query timeouts.\n- Include Express mount prefixes in request logs without logging query strings.\n- Preserve original request data while keeping parsed values inreq.validated.\n\n## Validation\n- 4 focused Jest suites passed (38 tests).\n-/healthintegration suite could not run because the current branch baseline has a pre-existing parse error insrc/config.js.\n\nCloses #376\nCloses #377\nCloses #378\nCloses #379","head": "fix/issues-376-377-378-379",
"headOwner": "rikkk-j",
"base": "main",
"draft": false
}
The branch pushed successfully to your fork. The PR API rejected creation with “must be a collaborator,” despite the pushed fork branch, so I’m opening GitHub’s comparison page for that fork and will try the web flow.
Opened
BrowserRead
BrowserRead , lines 1 to 160
The branch is now pushed to your own fork as requested. The PR tool still cannot create a PR without an authenticated collaborator session, and the browser page is logged out; I’m doing a final clean-tree check and will leave you the exact compare link with all four closing lines ready.
Ran terminal command: git status --short --branch; git log -1 --oneline; git branch -vv
Starting: Open PR closing issues (5/5)
You were right about the account. The branch is now pushed to your fork,
rikkk-j/smartdrop-backend, asfix/issues-376-377-378-379at commitd211b64; the worktree is clean.The fixes cover circuit-breaker results, database health pings, mounted request paths, and preserving raw request data. The focused suites passed: 38 tests across 4 suites. The
/healthintegration suite could not run because the existingconfig.jshas a parse error.I couldn’t create the PR: GitHub’s PR API returned “must be a collaborator,” and the browser session is signed out. The pushed branch is ready on the PR comparison page. Use an authenticated GitHub session with access to open it; the PR body should include these separate lines:
Closes #376
Closes #377
Closes #378
Closes #379