fix: resolve factory and farming-pool issues - #422
Merged
ritaifeoluwa merged 2 commits intoSep 27, 2026
Merged
Conversation
|
@greyforreal Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
✅ Deploy Preview for sdcontracts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- closes SmartDropLabs#373: Move pool_crtd event emission after pool initialization succeeds to prevent phantom pool events on failures - closes SmartDropLabs#374: Add admin address validation in initialize to prevent zero-address admin lockout - closes SmartDropLabs#375: Add pool_status query for centralized individual pool health monitoring - closes SmartDropLabs#376: Update lock_ledger on additional deposits to enforce consistent lock periods
greyforreal
force-pushed
the
fix/factory-farming-issues
branch
from
September 27, 2026 18:29
8d994d2 to
d67697b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #373
Move pool_crtd event emission after pool initialization succeeds to prevent phantom pool events on failures
Closes #374
Add admin address validation in initialize to prevent zero-address admin lockout
Closes #375
Add pool_status query for centralized individual pool health monitoring
Closes #376
Update lock_ledger on additional deposits to enforce consistent lock periods