fix(farming-pool, vesting-wallet): boost config, pause guard, cliff test, wasm hash query - #431
Merged
ritaifeoluwa merged 1 commit intoSep 27, 2026
Conversation
…rd, and cliff release test - Return the user's checkpointed multiplier from get_boost_config instead of the live global multiplier, consistent with credit accrual (SmartDropLabs#413) - Confirm set_boost is already guarded by require_staking_not_paused which checks the general pause flag (SmartDropLabs#411) - Add test_release_immediately_after_cliff covering release at the exact cliff boundary (SmartDropLabs#412) - Verify pool_wasm_hash query already works correctly with proper guards and documentation (SmartDropLabs#414) Closes SmartDropLabs#413, Closes SmartDropLabs#412, Closes SmartDropLabs#411, Closes SmartDropLabs#414
|
@ikechi-woke Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
✅ Deploy Preview for sdcontracts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserStake.multiplier(captured at boost/stake time) instead of the live global multiplier, making it consistent with how credits are actually calculated. Falls back to the current global multiplier only when the user has no active stake.set_boostis already protected viarequire_staking_not_paused(), which checks both the general pause flag and the staking-specific pause flag. No additional code change needed.test_release_immediately_after_cliffcovering the exact cliff boundary — verifies nothing is releasable one ledger before the cliff, tokens vest at the cliff, andrelease()transfers the correct amount.pool_wasm_hashfunction works correctly withrequire_initializedguard, TTL bump, typed result, and documentation.Closes #413, Closes #412, Closes #411, Closes #414
Test plan
get_boost_configreturns the checkpointed multiplier from the user's stake, not the current global multiplierset_boostrejects calls when the pool is paused (already covered byrequire_staking_not_paused)test_release_immediately_after_cliff— confirms cliff boundary behaviorpool_wasm_hashreturns the correct WASM hash after initialization