fix: resolve bounty issues #470–#473 - #495
Merged
ritaifeoluwa merged 1 commit intoSep 24, 2026
Merged
ritaifeoluwa merged 1 commit into
ritaifeoluwa merged 1 commit into
Conversation
- SmartDropLabs#473: Include test files in tsconfig type-checking and fix all surfaced type errors (missing imports, incomplete mocks, Buffer vs Uint8Array, unsafe casts, duplicate declarations) - SmartDropLabs#470: Define light-mode body background in globals.css so there is no flash of white before Chakra theme tokens hydrate - SmartDropLabs#472: Stop double-formatting TVL in PlatformStats — getPlatformStats already returns a toLocaleString-formatted display string - SmartDropLabs#471: Never expose window.__queryClient in production, even when NEXT_PUBLIC_E2E is set (E2E runs against next dev / development) Also fixes pre-existing type errors that blocked `pnpm typecheck` (missing useEffect import, duplicate stepRef, SkeletonBar responsive prop types) now that tests are included in the compilation.
❌ Deploy Preview for smart-drop failed.
|
❌ Deploy Preview for spiffy-melomakarona-eb1e8a failed.
|
|
@TheCodingChef-eth Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**/*.test.ts(x)in tsconfig; fix all type errors surfacedbodybackground (no white flash pre-hydration)getPlatformStatsalready returns display string)window.__queryClientin production, even withNEXT_PUBLIC_E2ETesting
pnpm typecheckpasses (was failing on main once tests were included)pnpm lintblocked by pre-existing parent ESLint config conflict