fix: prices lookup cooldown, factory warning, bounded responses, dev-stack docs - #502
Merged
ritaifeoluwa merged 1 commit intoSep 25, 2026
Merged
Conversation
…se reads, and dev-stack docs
|
@gboigwe Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for spiffy-melomakarona-eb1e8a failed.
|
❌ Deploy Preview for smart-drop failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #486
Closes #487
Closes #488
Closes #489
Changes
sorobanServiceis already initialized lazily (not at import).initialize()now returns early when no factory contract is configured, and theFactory contract not initializedwarning is logged once instead of on every load.src/lib/safe-fetch.tswithreadJsonWithLimit. It rejects when the declaredContent-Lengthis over 5 MiB and also counts the streamed body, so a missing or understated header is still caught. It is used for the Horizon account fetch, the leaderboard API and backend requests, and an oversized backend response now surfaces as an error instead of an empty body. Unit tests cover the reader.docs/dev-stack.md(whatscripts/dev-stack.shstarts, when to use it, prerequisites, what each run does, files, troubleshooting) and linked it from the README.Scope notes